fix: do not require a TLS client cert when InsecureSkipVerify is false#8525
Merged
traefiker merged 7 commits intotraefik:v2.5from Oct 26, 2021
Merged
fix: do not require a TLS client cert when InsecureSkipVerify is false#8525traefiker merged 7 commits intotraefik:v2.5from
traefiker merged 7 commits intotraefik:v2.5from
Conversation
kevinpollet
added
status/2-needs-review
kind/bug/fix
2 tasks
kevinpollet
force-pushed
the
fix-client-tls-cert
branch
2 times, most recently
from
f6fd18d to
1419fdd
Compare
kevinpollet
force-pushed
the
fix-client-tls-cert
branch
2 times, most recently
from
9803583 to
d377366
Compare
mpl
approved these changes
Oct 25, 2021
traefiker
added
bot/merge-retry-1
status/4-merge-in-progress
and removed
bot/merge-retry-1
labels
traefiker
force-pushed
the
fix-client-tls-cert
branch
from
d5fd18c to
537cf99
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the behaviour of the
CreateTLSConfigmethod which requires a TLS client cert when theInsecureSkipVerifyoption is set tofalse.The
InsecureSkipVerifyoption is only used to disable the verification of the server certificate and is not related to TLS client authentication.Motivation
Related to #5604
More
Additional Notes
Co-authored-by: Tom Moulard tom.moulard@traefik.io