Skip to content

Conversation

@tomMoulard
Copy link
Collaborator

What does this PR do?

This PR fixes text overflow in the dashboard.
It provides a better readability to middleware REGEXP panel by hiding the overflow with ellipsis and display a tooltip when the mouse hovers the regexp(e.g. see screenshots).
This PR re-uses the overflow functionality introduced in #7535.

Motivation

Fix a visual problem when using middlewares

Fixes #6947

More

  • [ ] Added/updated tests
  • [ ] Added/updated documentation

Additional Notes

From To
Screenshot from 2022-01-13 11-25-35 Screenshot from 2022-01-13 11-32-20
Screenshot from 2022-01-13 11-31-47 Screenshot from 2022-01-13 11-31-34
Screenshot from 2022-01-13 12-06-06 Screenshot from 2022-01-13 12-06-15
Screenshot from 2022-01-13 12-09-36 Screenshot from 2022-01-13 12-09-48

@tomMoulard
Copy link
Collaborator Author

Preview in dark mode:
Screenshot from 2022-01-13 13-55-33

@ldez ldez changed the title Fix middleware REGEXPs display Fix middleware regexp's display Jan 13, 2022
Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@kevinpollet kevinpollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@traefiker traefiker merged commit 8cd4547 into traefik:v2.5 Jan 13, 2022
@tomMoulard tomMoulard deleted the fix-dashboard-regexp branch January 13, 2022 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants