Skip to content

Comments

Mitigate memory leak#8706

Merged
traefiker merged 1 commit intotraefik:v2.5from
mpl:gor
Jan 17, 2022
Merged

Mitigate memory leak#8706
traefiker merged 1 commit intotraefik:v2.5from
mpl:gor

Conversation

@mpl
Copy link
Collaborator

@mpl mpl commented Jan 17, 2022

What does this PR do?

This PR bumps the mux dependency version, because it contains a work-around to mitigate a memory leak.

Motivation

To fix a memory leak, which might be the one observed at #7964 for example.

More

- [ ] Added/updated tests
- [ ] Added/updated documentation

Additional Notes

#8044, #7533

Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@ldez ldez added the bot/light-review decreases the number of required LGTM from 3 to 1. label Jan 17, 2022
Copy link
Member

@kevinpollet kevinpollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@traefiker traefiker merged commit 4071f1e into traefik:v2.5 Jan 17, 2022
@traefiker traefiker removed status/3-needs-merge bot/light-review decreases the number of required LGTM from 3 to 1. labels Jan 17, 2022
@darkl0rd
Copy link

Is this also affecting Traefik 1.7? And if so, will this be backported? (#7191)

@llussy
Copy link
Contributor

llussy commented Mar 7, 2022

Hi, is there a fix for version 1.7? I didn't find a newer version.

@tfny
Copy link
Contributor

tfny commented Mar 8, 2022

We are looking into it, we will get back to you soon. :)

@tfny tfny self-assigned this Mar 10, 2022
@ddtmachado
Copy link
Contributor

ddtmachado commented Mar 15, 2022

@darkl0rd @llussy Just to clarify version 1.7 is not supported anymore and we are preparing a new doc section that would make it easy to find what versions we are actively maintaining and what are the rules for that, including exceptions if any.

The PR is still under review, and feedback is welcomed as always.

Having said that, yes this problem affects 1.7 and we might look at backporting it at some point if really needed. Really needed in this context means a customer is affected and couldn't finish the migration to 2.x in time or hit some blocker in doing so, then we might consider a priority to avoid production issues until the migration is finished.

Of course if someone in the community is willing to work on it and backport the fix into 1.7 I see no reason why we would not review and merge it as soon as possible.

@mpl mpl deleted the gor branch April 13, 2022 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

10 participants