Re-add missing writeheader call in flush#8957
Merged
traefiker merged 2 commits intotraefik:v2.6from Apr 21, 2022
Merged
Conversation
mpl
added
kind/enhancement
kevinpollet
force-pushed
the
customwrite
branch
from
237e523 to
4854db9
Compare
kevinpollet
added
kind/bug/fix
mpl
changed the title
mpl
changed the title
kevinpollet
force-pushed
the
customwrite
branch
from
4854db9 to
11b9c4a
Compare
kevinpollet
force-pushed
the
customwrite
branch
from
11b9c4a to
8b6be4d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR re-adds a missing writeheader call (that was removed in #8932 ) in Flush that is needed in case Flush is called before anything else.
This PR also simplifies the Write(header) methods of the codeCatcher.
Motivation
Readability and maintainability.
More
- [ ] Added/updated tests- [ ] Added/updated documentationAdditional Notes
Co-authored-by: Kevin Pollet pollet.kevin@gmail.com