Fix HostRegexp and Query muxers #9131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes an issue with the
HostRegexpmatcher and theQuerymatcher.Before the fix,
HostRegexpused an empty host if the url path was http://@/ whereas theHostmatcher used the host header,HostRegexpnow uses the host header in case the url contains an empty host.Before the fix
Queryconsidered semi-colons as invalid and so ignored all the query params, Query now handles;as separator and sanitizes those;with&when the request is forwarded to the backend.Motivation
Fix some weird behaviour with negative matchers.
More