Skip to content

Conversation

@markormesher
Copy link
Contributor

What does this PR do?

Fix the wording of the default behaviour for the namespaces config key for the K8s provider.

Motivation

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

@ldez ldez changed the title Mormesher/fix namespaces docs doc: fix namespaces Jul 30, 2022
@rtribotte rtribotte added this to the 2.8 milestone Aug 1, 2022
@kevinpollet kevinpollet changed the title doc: fix namespaces Fix wording of default behavior for namespaces option Aug 1, 2022
Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

Copy link
Member

@kevinpollet kevinpollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@rtribotte rtribotte added status/2-needs-review bot/light-review decreases the number of required LGTM from 3 to 1. status/3-needs-merge and removed status/2-needs-review labels Aug 1, 2022
@traefiker traefiker merged commit 146991e into traefik:v2.8 Aug 1, 2022
@traefiker traefiker removed status/3-needs-merge bot/light-review decreases the number of required LGTM from 3 to 1. labels Aug 1, 2022
@markormesher markormesher deleted the mormesher/fix-namespaces-docs branch August 1, 2022 08:19
@tfny
Copy link
Contributor

tfny commented Aug 4, 2022

Congrats on merging your first pr with us @markormesher! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants