Add missing context in backoff for Marathon #9246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtribotte
added
status/2-needs-review
area/provider/marathon
kind/bug/fix
kevinpollet
added
bot/light-review
traefiker
force-pushed
the
fix-missing-backoffwithcontext
branch
from
d89652c to
8bd3431
Compare
traefiker
removed
status/3-needs-merge
bot/light-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR is only refactoring the backoff declaration to add the context shared with the operation.
It will prevent the operation from backing off if the context has been canceled.
Motivation
To be consistent with what is done in other providers' implementations.
More
Additional Notes