Allow editing tag:value in TagSelector#235
Merged
jmattheis merged 3 commits intotraggo:masterfrom Feb 1, 2026
Merged
Conversation
Contributor
|
Would this potentially cause problems for scrolling on mobile? |
Contributor
Author
|
Good question. I did a small test using Firefox for iOS and didn't accidentally trigger an edit. Please give it a try and let me know otherwise. |
Contributor
Seems to be working well on mobile, you'd have to accidentally tap the screen somewhere to trigger it, I don't think it'll happen by accident when scrolling. |
jmattheis
force-pushed
the
click-to-edit
branch
from
509fe71 to
442acc1
Compare
jmattheis
approved these changes
Feb 1, 2026
ui/src/tag/TagSelector.tsx
Outdated
| const onTagClicked = (entry: TagSelectorEntry) => { | ||
| if (!removeWhenClicked) { | ||
| // Prevent overwriting text that's already being edited | ||
| if (currentValue) { |
Member
There was a problem hiding this comment.
The normal tag selector supports backspace to edit and ctrl+backspace to delete. I've changed this, so clicking the tag works similar.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #92
This change allows for editing of a tag.
It's implemented similarly to the existing Backspace functionality - when we click on a TagChip, it's removed from the Entries list and the tag:value text is placed in the TextInput.
Care is taken to preserve an existing value part when creating a new tag.
Clicking tags doesn't do anything when there's stuff in the input, to avoid overwriting the input's content without saving.
edit-tags.mp4