ci: consolidate GitHub Actions workflows#427
Merged
Conversation
Consolidate and improve GitHub Actions workflows: Deleted redundant/outdated workflows: - claude-code-review.yml - No longer used - claude.yml - No longer used - pre-commit.yml - Merged into static-checks.yml Renamed for clarity: - comp-integration.yml → component-integration.yml - integration.yml → system-integration.yml New workflows: - static-checks.yml - Comprehensive static analysis (shellcheck, hadolint, actionlint) Improvements: - Add actionlint configuration (.github/actionlint.yaml) - Update dependabot configuration with cooldown settings - Improve workflow concurrency settings - Pin actions to SHA hashes for security - Add better job dependencies and caching Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
dguido
requested review from
hbrodin,
michaelbrownuc and
ret2libc
as code owners
ret2libc
approved these changes
Jan 26, 2026
hbrodin
added a commit
that referenced
this pull request
Apr 27, 2026
* ci: shell-quote env values for system integration tests Two bugs in the env file step prevented the weekly System Integration Tests from ever passing since #427 (2026-01-26): 1. The deletion regex `/^KEY=/` did not match the template's `export KEY=replace-me` lines, leaving stale `replace-me` placeholders in the file alongside the appended real values. 2. Appended values were not shell-quoted, so `source ./env` in deployment/crs-architecture.sh treated whitespace and metacharacters as shell syntax. The `OTEL_TOKEN` secret (a `Bearer <token>` header) tripped this with `command not found` on the token component. The same gap was a code-execution sink: a secret containing `$(...)` or backticks would execute on the runner at source time. Fix: strip with `(export[[:space:]]+)?` so template lines are actually removed, and write with `printf 'export %s=%q\n'` so every value is shell-escaped — defending against both whitespace and injection. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * ci: drop placeholder block from ci-env.template The placeholder lines (`export KEY=replace-me`) only existed because the pre-rewrite step substituted into them with `sed -i "s|KEY=.*|...|"`. The new `printf %q` write path doesn't need them, so removing them at the source eliminates the entire delete-then-rewrite dance. Drops `strip_var` and the for-loop. The workflow step is now: copy the static template, then append shell-quoted assignments for every secret the env: block injects. GHCR_AUTH is no longer defined at all, so the `[ -n "$GHCR_AUTH" ]` warning branch in crs-architecture.sh:63 fires as intended. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidate and improve GitHub Actions workflows for better maintainability and security.
Changes
Deleted Redundant/Outdated Workflows
claude-code-review.yml- No longer usedclaude.yml- No longer usedpre-commit.yml- Merged into static-checks.ymlRenamed for Clarity
comp-integration.yml→component-integration.ymlintegration.yml→system-integration.ymlNew Workflows
static-checks.yml- Comprehensive static analysis (shellcheck, hadolint, actionlint, zizmor)Improvements
.github/actionlint.yaml)Risk
Medium - CI changes affect all developers. Easy to rollback if issues.
Testing
🤖 Generated with Claude Code