Harden devcontainer: pin digests, guard SYS_ADMIN, fix mount filters#20
Merged
Harden devcontainer: pin digests, guard SYS_ADMIN, fix mount filters#20
Conversation
Address review feedback from #14–#19: - Pin base image and uv with SHA256 digests (#15) - Install fzf from GitHub releases instead of apt (#14) - Add SYS_ADMIN capability guard to prevent remount attacks (#16) - Fix mount filter to use target paths instead of source prefixes (#17) - Fix temp file leak in extract_mounts_to_file (#17) - Sort apt packages alphabetically (#18) - Remove unused Tailscale feature (#19) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
check_no_sys_admin()guard to block SYS_ADMIN capability that would defeat the read-only .devcontainer mount (Add SYS_ADMIN capability guard to install.sh #16)Closes #14, closes #15, closes #16, closes #17, closes #18, closes #19
Test plan
shellcheck install.sh— cleanpython3 -m py_compile post_install.py— cleanjq . devcontainer.json— valid JSONhadolint Dockerfile— only pre-existing informational warnings (DL3008, DL3059)docker buildsucceedsfzf --version→ 0.67.0fzf --zshintegration worksuv --version→ 0.10.0🤖 Generated with Claude Code