Add Jinja2 template validation test and pre-commit hook#45
Merged
Conversation
Catch template syntax errors early with a unit test that parses and renders the default cloud-init template, and a pre-commit hook that validates all templates in dropkit/templates/ on change. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
DarkaMaul
approved these changes
Feb 24, 2026
Collaborator
DarkaMaul
left a comment
DarkaMaul
left a comment
There was a problem hiding this comment.
🤦 Sorry for the spurious comment before!
Much better this way
DarkaMaul
reviewed
Feb 24, 2026
| hooks: | ||
| - id: jinja2-check | ||
| name: jinja2 template syntax | ||
| entry: uv run python -c "import sys; from jinja2 import Template; [Template(open(f).read()) for f in sys.argv[1:]]" |
Collaborator
There was a problem hiding this comment.
Suggested change
| entry: uv run python -c "import sys; from jinja2 import Template; [Template(open(f).read()) for f in sys.argv[1:]]" | |
| entry: uv run --with jinja2 python -c "import sys; from jinja2 import Template; [Template(open(f).read()) for f in sys.argv[1:]]" |
Maybe that's more resilient?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jinja2-checkpre-commit hook that validates all templates indropkit/templates/on changeTest plan
uv run pytest tests/test_cloudinit.py -v— all 3 tests passprek run --all-files— all hooks pass including newjinja2-check{% if %}) and verify both the test and hook catch it🤖 Generated with Claude Code