Aligned parameter substitutions #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `MacroExpansion::AlignedParameterSubstitutions()` to map each of a macro expansion's parameters to a vector of stmts that the parameter's substitutions cover/align with. - Add `MacroExpansion::ParameterUseCounts()` to map each of the macro expansion's parameters to the number of times it was substituted into the expansion. - Define the `<` operator for macros so that we can use `MacroParameter`s as map keys.
- Add binary print-aligned-parameter-substitutions to enable testing of `MacroExpansion::AlignedParameterSubstitutions()`. - Update appropriate CMake files.
pgoodman
approved these changes
May 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MacroExpansion::AlignedParameterSubstitutions()to map each of a macro's parameters to a vector ofStmts that align with those parameters' substitutions in the macro expansion.MacroExpansion::ParameterUseCounts()to map each of the macro's parameters to the number of times it was substituted into the macro expansion.With these two methods combined, users can check if every one of a macro expansion's parameter substitutions align with a
Stmt. This is demonstrated in the new binary,print-aligned-parameters-substitutions. This will be useful when deciding what macro expansions to lower down to MLIR, and for getting the regions of code that should emitted for each of the macro expansion's arguments.