Update CI#214
Merged
Merged
Conversation
ekilmer
force-pushed
the
update-windows-ci
branch
from
7203fe3 to
bf5a786
Compare
MSVC links /fsanitize=address binaries against clang_rt.asan_dynamic-x86_64.dll, which only sits on PATH inside a VS developer prompt. ctest launched the test binaries in a bare shell, so they failed at startup with STATUS_DLL_NOT_FOUND (0xc0000135). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
ekilmer
force-pushed
the
update-windows-ci
branch
from
bf5a786 to
be529f7
Compare
Merged
Collaborator
|
I think this one is good. The referenced PR, #211, will probably need some changes once this is merged, as it also changes the CI runner VS version (to an older version than this PR does). But that's a relatively minor thing, and the rest of that PR looks good. Can you squash/merge, or do you need me to boop the button? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pinact run --update)std::filesystemworkaround. It's 2026 nowgh-action-pypi-publishworkflow guidance (not tested... PYPI project is archived)ilammy/msvc-dev-cmdaction