Canonical byte lookup bugfixes and datastructure optimization#95
Merged
carsonharmon merged 3 commits intomasterfrom Sep 10, 2020
Merged
Canonical byte lookup bugfixes and datastructure optimization#95carsonharmon merged 3 commits intomasterfrom
carsonharmon merged 3 commits intomasterfrom
Conversation
carsonharmon
suggested changes
Sep 10, 2020
carsonharmon
approved these changes
Sep 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@carsonharmon this is a small one that fixes the canonical byte lookup for grammar extraction. I changed some of the instrumentation datastructures and how we iterate over them, so can you please take a quick look to make sure it all seems sane? Feel free to merge this yourself if/when it looks good.