Skip to content

style: fix formatting issues across 27 plugin files#97

Closed
dkmcintyre wants to merge 1 commit intotrailofbits:mainfrom
SafariCircuitsLLC:fix/formatting-cleanup
Closed

style: fix formatting issues across 27 plugin files#97
dkmcintyre wants to merge 1 commit intotrailofbits:mainfrom
SafariCircuitsLLC:fix/formatting-cleanup

Conversation

@dkmcintyre
Copy link
Copy Markdown
Contributor

Summary

  • Fix missing newlines at end of file (23 files)
  • Fix trailing whitespace (5 files)

Pre-commit hooks (end-of-file-fixer and trailing-whitespace) now pass for all files.

Test plan

  • pre-commit run --all-files passes (except shellcheck which requires system install)
  • No functional changes - formatting only

🤖 Generated with Claude Code

Pre-commit hooks auto-fixed missing newlines at EOF and trailing
whitespace to satisfy end-of-file-fixer and trailing-whitespace checks.

Co-Authored-By: Claude Code <noreply@anthropic.com>
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Feb 18, 2026

CLA assistant check
All committers have signed the CLA.

@dguido
Copy link
Copy Markdown
Member

dguido commented Feb 18, 2026

Review Summary

Five-source review: pr-review-toolkit (code-reviewer, silent-failure-hunter, pr-test-analyzer) + OpenAI Codex + Google Gemini.

Findings

All 5 review sources confirmed: no issues found. Every change is mechanical whitespace normalization (EOF newlines, trailing whitespace, trailing blank lines). No content was altered.

# Severity Finding Resolution
1 P4 PR has merge conflicts against main Informational: needs rebase before merge
2 P4 end-of-file-fixer and trailing-whitespace only run in pre-commit, not CI — drift will recur Informational: consider adding to CI validate.yml
3 P4 PR description says "23 files" for EOF fixes — actual breakdown is 15 missing-EOF-newline + 11 trailing-blank-line + 5 trailing-whitespace (the hook conflates the first two) Informational: minor description inaccuracy

Verification

  • JSON: plugin.json validates cleanly (python3 -m json.tool)
  • SKILL.md frontmatter: All 46 SKILL.md files have valid name and description
  • Marketplace consistency: All 17 plugins validated
  • Hardcoded paths: None found
  • EOF newlines: All 27 changed files end with exactly one newline (verified with xxd)

No fixes needed

All findings are P4 (informational). No code changes required.


Reviewed with Claude Code, OpenAI Codex, and Google Gemini

@dguido
Copy link
Copy Markdown
Member

dguido commented Feb 18, 2026

Rebased this branch onto latest main to resolve merge conflicts. 11 of the 27 files were already fixed on main, so the rebased diff covers 16 files.

Since I can't push to the fork, I've pushed the rebased branch to origin/fix/formatting-cleanup and will open a replacement PR. Closing this one — thank you @dkmcintyre for the contribution!

@dguido dguido closed this Feb 18, 2026
@dguido dguido reopened this Feb 18, 2026
@dguido dguido closed this Feb 18, 2026
dguido added a commit that referenced this pull request Feb 18, 2026
check-yaml, check-json, end-of-file-fixer, and trailing-whitespace
only ran locally via pre-commit. Contributors who skip pre-commit
can introduce formatting drift (see #97). Add a CI job using
pre-commit/action to enforce these four hooks on every PR.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
dguido added a commit that referenced this pull request Feb 18, 2026
* ci: enforce pre-commit formatting hooks in CI

check-yaml, check-json, end-of-file-fixer, and trailing-whitespace
only ran locally via pre-commit. Contributors who skip pre-commit
can introduce formatting drift (see #97). Add a CI job using
pre-commit/action to enforce these four hooks on every PR.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* ci: consolidate lint jobs into single pre-commit pass

Run all pre-commit hooks (ruff, shellcheck, shfmt, check-yaml,
check-json, end-of-file-fixer, trailing-whitespace) in one job
instead of separate CI jobs per tool. Fixes the extra_args error
where pre-commit run only accepts one hook ID positionally.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* style: fix trailing whitespace and EOF in semgrep-rule-creator

Pre-commit hooks caught two files missed by the earlier formatting
PR: trailing blank line in quick-reference.md and trailing
whitespace plus missing final newline in workflow.md.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants