feat(#59): align status brackets and add explicit state descriptors #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace formatDuration() with formatStatus() for state-aware status text - Pending tasks now show [Pending] instead of empty - Running tasks show [Running X.Xs] - Completed tasks show [Took X.Xs] - Cached tasks show [Cached X.Xs] - Failed tasks show [Failed X.Xs] - Add dynamic alignment for status brackets - calculateRowNameWidth() computes width for individual rows - calculateMaxNameWidth() finds maximum width across visible rows - renderTreeRow() inserts padding to align brackets vertically - Update fullScreenLogView() to use new formatStatus() - Add comprehensive tests for status formatting and alignment - Test all status states (Pending, Running, Done, Cached, Failed) - Test width calculation logic - Update existing tests to match new format Closes #59
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace formatDuration() with formatStatus() for state-aware status text
Add dynamic alignment for status brackets
Update fullScreenLogView() to use new formatStatus()
Add comprehensive tests for status formatting and alignment
Closes #59