Skip to content

fix(forms): add delay before resetting scan state on trigger release #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mikestankavich merged 8 commits into from
Jan 14, 2026
Merged

fix(forms): add delay before resetting scan state on trigger release #109

mikestankavich merged 8 commits into from
Jan 14, 2026

Conversation

@mikestankavich
Copy link
Contributor

@mikestankavich mikestankavich commented Jan 13, 2026

Summary

  • Fixes race condition where trigger release was processed before barcode store subscription could fire
  • Adds 150ms delay before resetting isScanningRef on trigger release
  • Allows barcode data to be captured on Windows Chrome (affected more than macOS due to JS event loop timing differences)

Root Cause

When scanning barcodes in Asset/Location forms via hardware trigger:

  1. Trigger pressed → isScanningRef.current = true
  2. CS108 scans barcode → data goes to useBarcodeStore
  3. Trigger released → isScanningRef.current = false ← happened too fast
  4. Store subscription fires → checks isScanningRef.current → false, discards barcode!

Test plan

  • Test barcode scanning in Asset form on Windows Chrome
  • Test barcode scanning in Location form on Windows Chrome
  • Verify macOS behavior unchanged
  • Verify trigger press/release timing works correctly

🤖 Generated with Claude Code

@claude
fix(forms): add delay before resetting scan state on trigger release
3a4ab86 
Fixes a race condition where the trigger release event was processed
before the barcode store subscription could fire, causing scanned
barcode data to be discarded. This affected Windows Chrome more than
macOS due to different JavaScript event loop timing.

The fix adds a 150ms delay before resetting isScanningRef on trigger
release, giving the barcode store subscription time to process any
pending barcode data.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@github-actions
Copy link

github-actions bot commented Jan 13, 2026

🚀 Preview Deployment Update

✅ This PR has been successfully merged into the preview branch.

The preview environment will update shortly at: https://app.preview.trakrf.id

github-actions bot added a commit that referenced this pull request Jan 13, 2026
@github-actions
Merge PR #109: fix(forms): add delay before resetting scan state on t…
8d557a5 
…rigger release
@claude
fix(forms): use deterministic count-based scan session tracking
c1e559e 
Replace timing-based race condition fix with deterministic approach:
- Track barcode count when scan starts (startCount)
- Subscription compares barcodes.length > startCount
- Session stays active 2s after trigger release to catch late data
- New trigger during cooldown cancels old session and starts fresh

This eliminates timing dependency entirely - comparison is deterministic.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@github-actions
Copy link

github-actions bot commented Jan 14, 2026

🚀 Preview Deployment Update

✅ This PR has been successfully merged into the preview branch.

The preview environment will update shortly at: https://app.preview.trakrf.id

github-actions bot added a commit that referenced this pull request Jan 14, 2026
@github-actions
Merge PR #109: fix(forms): add delay before resetting scan state on t…
3cd19be 
…rigger release
Mike Stankavich and others added 2 commits January 13, 2026 18:57
@claude
fix(forms): delay mode switch until after barcode data received
385b118 
Don't call dm.setMode() immediately on trigger release - this was
aborting the CS108 scan mid-transmission causing truncated reads.

Now mode switch happens:
- Immediately after barcode data received (via endScanSession)
- OR after 2s timeout if no data (fallback cleanup)

This gives the CS108 time to finish transmitting barcode data.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@claude
fix(forms): 500ms grace period before mode switch on trigger release
45a99d0 
- Give CS108 500ms to finish transmitting data after trigger release
- Switch modes after 500ms, keep session open 1.5s more for late data
- End immediately on clean read (endScanSession cancels timeouts)

Total timing: 500ms grace + 1.5s late data window = 2s max
Clean read: immediate mode switch, no waiting

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@github-actions
Copy link

github-actions bot commented Jan 14, 2026

🚀 Preview Deployment Update

✅ This PR has been successfully merged into the preview branch.

The preview environment will update shortly at: https://app.preview.trakrf.id

github-actions bot added a commit that referenced this pull request Jan 14, 2026
@github-actions
Merge PR #109: fix(forms): add delay before resetting scan state on t…
258be92 
…rigger release
@claude
fix(forms): prevent blur race when clicking scan button
8fa355a 
Add onMouseDown with preventDefault to stop the tag input from losing
focus when clicking the Scan button. This prevents the button from
being disabled before the click event fires.

Applied to both AssetForm and LocationForm.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@github-actions
Copy link

github-actions bot commented Jan 14, 2026

🚀 Preview Deployment Update

✅ This PR has been successfully merged into the preview branch.

The preview environment will update shortly at: https://app.preview.trakrf.id

github-actions bot added a commit that referenced this pull request Jan 14, 2026
@github-actions
Merge PR #109: fix(forms): add delay before resetting scan state on t…
40b988e 
…rigger release
@claude
fix(forms): keep CS108 in barcode mode full 2s after trigger release
f3f7575 
Don't switch modes until data arrives or 2s timeout - more forgiving
for slow machines. Mode switch only happens via:
- endScanSession() when data arrives (immediate)
- 2s timeout cleanup (fallback)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@github-actions
Copy link

github-actions bot commented Jan 14, 2026

🚀 Preview Deployment Update

✅ This PR has been successfully merged into the preview branch.

The preview environment will update shortly at: https://app.preview.trakrf.id

github-actions bot added a commit that referenced this pull request Jan 14, 2026
@github-actions
Merge PR #109: fix(forms): add delay before resetting scan state on t…
2362a0d 
…rigger release
@claude
fix(forms): use raw barcode data like BarcodeScreen does
8d8a41c 
Remove stripAimIdentifier - was causing empty data on some machines.
Now passes raw barcode.data directly, same as BarcodeScreen displays.

Also switched from subscription to reactive state for barcode detection
which is more reliable on slow machines.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@github-actions
Copy link

github-actions bot commented Jan 14, 2026

🚀 Preview Deployment Update

✅ This PR has been successfully merged into the preview branch.

The preview environment will update shortly at: https://app.preview.trakrf.id

github-actions bot added a commit that referenced this pull request Jan 14, 2026
@github-actions
Merge PR #109: fix(forms): add delay before resetting scan state on t…
2e8fe10 
…rigger release
@claude
fix(forms): restore AIM stripping with debug logging
2d1cefa 
Re-add stripAimIdentifier to extract data after QR prefix (Q]Q1...).
Added console.debug logging to help diagnose issues on Tim's machine.

Example: "Q]Q1000000000000000000000130" -> "000000000000000000000130"

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@github-actions
Copy link

github-actions bot commented Jan 14, 2026

🚀 Preview Deployment Update

✅ This PR has been successfully merged into the preview branch.

The preview environment will update shortly at: https://app.preview.trakrf.id

github-actions bot added a commit that referenced this pull request Jan 14, 2026
@github-actions
Merge PR #109: fix(forms): add delay before resetting scan state on t…
57444fa 
…rigger release
@github-actions
Copy link

github-actions bot commented Jan 14, 2026

🚀 Preview Deployment Update

✅ This PR has been successfully merged into the preview branch.

The preview environment will update shortly at: https://app.preview.trakrf.id

github-actions bot added a commit that referenced this pull request Jan 14, 2026
@github-actions
Merge PR #109: fix(forms): add delay before resetting scan state on t…
6fc5a78 
…rigger release
@mikestankavich mikestankavich force-pushed the fix/scan-to-input-race-condition branch from 93b789d to 2d1cefa Compare January 14, 2026 01:45
@github-actions
Copy link

github-actions bot commented Jan 14, 2026

🚀 Preview Deployment Update

✅ This PR has been successfully merged into the preview branch.

The preview environment will update shortly at: https://app.preview.trakrf.id

github-actions bot added a commit that referenced this pull request Jan 14, 2026
@github-actions
Merge PR #109: fix(forms): add delay before resetting scan state on t…
1d3474e 
…rigger release
github-actions bot added a commit that referenced this pull request Jan 14, 2026
@github-actions
Merge PR #109: fix(forms): add delay before resetting scan state on t…
790dcf3 
…rigger release
@mikestankavich mikestankavich merged commit a1b9c26 into main Jan 14, 2026
6 checks passed
@mikestankavich mikestankavich deleted the fix/scan-to-input-race-condition branch January 14, 2026 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mikestankavich