Skip to content

Add poster translations#823

Merged
michaldrabik merged 1 commit intotrakt:masterfrom
VSeryi:add_poster_translations
May 11, 2024
Merged

Add poster translations#823
michaldrabik merged 1 commit intotrakt:masterfrom
VSeryi:add_poster_translations

Conversation

@VSeryi
Copy link
Contributor

@VSeryi VSeryi commented May 4, 2024

Overview

This Pull Request introduces a version for Showly 2.0 that allows poster translations to be displayed based on the user's configured language.

It resolved Issues as #797 when a translation is available

Changes

  • Changed fetchEpisodeImage method to unify it with the rest of fetch"Media"Image
  • Changed the loadRemoteImage of the EpisodeImagesProvider to unify it with the style of the rest of the ImagesProviders.
  • Added getVoteScore method in TmdbImage to get a score based on count votes and average votes using wilson's score.
  • Changed the findBestImage method to choose the first image in the language selected by the user, or failing that, in English, or failing that, in ‘null’, or failing that, in whatever language there is, all of them sorted by their VoteScore.
  • Added clearing of image cache when switching languages

Acknowledgements

A huge thank you to everyone involved in developing Showly 2.0.

@VSeryi VSeryi force-pushed the add_poster_translations branch 4 times, most recently from 4f2de95 to 3321ec0 Compare May 7, 2024 17:05
@VSeryi VSeryi requested a review from michaldrabik May 7, 2024 17:30
@VSeryi VSeryi marked this pull request as draft May 7, 2024 18:39
@VSeryi VSeryi force-pushed the add_poster_translations branch from 3321ec0 to 3fdd6d7 Compare May 7, 2024 18:49
@VSeryi VSeryi marked this pull request as ready for review May 7, 2024 18:51
@VSeryi VSeryi force-pushed the add_poster_translations branch from 3fdd6d7 to c8aa9be Compare May 8, 2024 20:15
@VSeryi VSeryi force-pushed the add_poster_translations branch from c8aa9be to 916f5a2 Compare May 8, 2024 21:27
@michaldrabik michaldrabik merged commit 830d68e into trakt:master May 11, 2024
@VSeryi VSeryi deleted the add_poster_translations branch May 12, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants