chore / relicense project to gpl-3.0-or-later#2008
Merged
Conversation
replace the mit license with the gnu general public license v3 and update the license field in the client package manifest.
Contributor
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request formalizes the project's transition to a copyleft licensing model. By adopting the GPL-3.0-or-later, the project ensures that future contributions and derivatives remain open-source, aligning with the goal of maintaining software freedom for all users. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
 |
|
Overall Grade |
Security Reliability Complexity Hygiene Coverage |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| JavaScript |  |
Apr 1, 2026 10:25a.m. | Review ↗ |
| Test coverage | |
Apr 1, 2026 10:25a.m. | Review ↗ |
Code Coverage Summary
| Language | Line Coverage (Overall) |
|---|---|
| Aggregate | 80.5% |
| Javascript | 80.5% |
➟ Additional coverage metrics may have been reported. See full coverage report ↗
seferturan
approved these changes
Apr 1, 2026
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request transitions the project license from MIT to GPL-3.0-or-later, updating both the LICENSE file and the client package configuration. A critical issue was identified regarding the LICENSE file, which contains an incomplete and structurally incorrect version of the GNU General Public License v3, missing several sections and mislabeling others. The full, unaltered text of the license should be used to ensure legal compliance.
Comment on lines
+21
to
+304
| TERMS AND CONDITIONS | ||
|
|
||
| 0. Definitions. | ||
|
|
||
| "This License" refers to version 3 of the GNU General Public License. | ||
|
|
||
| "Copyright" also means copyright-like laws that apply to other kinds of | ||
| works, such as semiconductor masks. | ||
|
|
||
| "The Program" refers to any copyrightable work licensed under this | ||
| License. Each licensee is addressed as "you". "Licensees" and | ||
| "recipients" may be individuals or organizations. | ||
|
|
||
| To "modify" a work means to copy from or adapt all or part of the work | ||
| in a fashion requiring copyright permission, other than the making of an | ||
| exact copy. The resulting work is called a "modified version" of the | ||
| earlier work or a work "based on" the earlier work. | ||
|
|
||
| A "covered work" means either the unmodified Program or a work based | ||
| on the Program. | ||
|
|
||
| To "propagate" a work means to do anything with it that, without | ||
| permission, would make you directly or secondarily liable for | ||
| infringement under applicable copyright law, except executing it on a | ||
| computer or modifying a private copy. Propagation includes copying, | ||
| distribution (with or without modification), making available to the | ||
| public, and in some countries other activities as well. To | ||
| "convey" a work means any kind of propagation that enables other | ||
| parties to make or receive copies. Mere interaction with a user through | ||
| a computer network, without transfer of a copy, is not conveying. | ||
|
|
||
| An interactive user interface displays "Appropriate Legal Notices" | ||
| to the extent that it includes a convenient and prominently visible | ||
| feature that (1) displays an appropriate copyright notice, and (2) | ||
| tells the user that there is no warranty for the work (except to the | ||
| extent that warranties are provided), that licensees may convey the | ||
| work under this License, and how to view a copy of this License. If | ||
| the interface presents a list of user commands or options, such as a | ||
| menu, a prominent item in the list meets this criterion. | ||
|
|
||
| 1. Source Code. | ||
|
|
||
| The "source code" for a work means the preferred form of the work | ||
| for making modifications to it. "Object code" means any non-source | ||
| form of a work. | ||
|
|
||
| A "Standard Interface" means an interface that either is an official | ||
| standard defined by a recognized standards body, or, in the case of | ||
| interfaces specified for a particular programming language, one that | ||
| is widely used among developers working in that language. | ||
|
|
||
| The "System Libraries" of an executable work include anything, other | ||
| than the work as a whole, that (a) is included in the normal form of | ||
| packaging a Major Component, but which is not part of that Major | ||
| Component, and (b) serves only to enable use of the work with that | ||
| Major Component, or to implement a Standard Interface for which an | ||
| implementation is available to the public in source code form. A | ||
| "Major Component", in this context, means a major essential component | ||
| (kernel, window system, and so on) of the specific operating system | ||
| (if any) on which the executable work runs, or a compiler used to | ||
| produce the work, or an object code interpreter used to run it. | ||
|
|
||
| The "Corresponding Source" for a work in object code form means all | ||
| the source code needed to generate, install, and (for an executable | ||
| object code work) run the object code and to modify the work, including | ||
| scripts to control those activities. However, it does not include the | ||
| work's System Libraries, or general-purpose tools or generally available | ||
| free programs which are used unmodified with the work. For example, | ||
| Corresponding Source includes interface definition files associated | ||
| with source files for the work, and the source code for shared | ||
| libraries and dynamically linked subprograms that the work is | ||
| specifically designed to depend upon, such as by intimate data | ||
| communication or control flow between those parts and other | ||
| parts of the work. | ||
|
|
||
| The Corresponding Source need not include anything that users | ||
| can regenerate automatically from other parts of the Corresponding | ||
| Source. | ||
|
|
||
| The Corresponding Source for a work in source code form is that | ||
| same work. | ||
|
|
||
| 2. Basic Permissions. | ||
|
|
||
| All rights granted under this License are granted for the term of | ||
| copyright on the Program, and are irrevocable provided the stated | ||
| conditions are met. This License explicitly affirms your unlimited | ||
| permission to run the unmodified Program. The output from running a | ||
| covered work is covered by this License only if the output, by its | ||
| content, constitutes a covered work. This License acknowledges your | ||
| rights of fair use or other equivalent, as provided by copyright law. | ||
|
|
||
| You may make, run and propagate covered works that you do not | ||
| convey, without conditions so long as your license otherwise remains | ||
| in force. You may convey covered works to others for the sole purpose | ||
| of having them make modifications exclusively for you, or provide you | ||
| with facilities for running those works, provided that you comply with | ||
| the terms of this License in conveying all material for which you do | ||
| not control copyright. Those thus making or receiving copies of these | ||
| works from you must be made aware of the terms of this License. GPL | ||
| requires that modified versions are marked or identified as such. | ||
|
|
||
| When you convey a covered work, you waive any legal power to forbid | ||
| circumvention of technological measures to the extent such circumvention | ||
| is effected by exercising rights under this License with respect to | ||
| the covered work, and you disclaim any intention to limit operation or | ||
| modification of the work as a means of enforcing, against the work's | ||
| users, your or third parties' legal rights to forbid circumvention of | ||
| technological measures. | ||
|
|
||
| 4. Conveying Verbatim Copies. | ||
|
|
||
| You may convey verbatim copies of the Program's source code as you | ||
| receive it, in any medium, provided that you conspicuously and | ||
| appropriately publish on each copy an appropriate copyright notice; | ||
| keep intact all notices stating that this License and any | ||
| non-permissive terms added in accord with section 7 apply to the code; | ||
| keep intact all notices of the absence of any warranty; and give all | ||
| recipients of the Program a copy of this License along with the | ||
| Program. | ||
|
|
||
| You may charge any price or no price for each copy that you convey, | ||
| and you may offer support or warranty protection for a fee. | ||
|
|
||
| 5. Conveying Modified Source Versions. | ||
|
|
||
| You may convey a work based on the Program, or the modifications to | ||
| produce it from the Program, in the form of source code under the | ||
| terms of section 4, provided that you also meet all of these conditions: | ||
|
|
||
| a) The work must carry prominent notices stating that you modified | ||
| it, and giving a relevant date. | ||
|
|
||
| b) The work must carry prominent notices stating that it is | ||
| released under this License and any conditions added under section 7. | ||
| This requirement modifies the requirement in section 4 to "keep intact | ||
| all notices". | ||
|
|
||
| c) You must license the entire work, as a whole, under this | ||
| License to anyone who comes into possession of a copy. This | ||
| License will therefore apply, as well as any applicable section 7 | ||
| additional terms, to the whole of the work, and all its parts, | ||
| regardless of how they are packaged. This License gives no | ||
| permission to license the work in any other way, but it does not | ||
| invalidate such permission if you have separately received it. | ||
|
|
||
| d) If the work has interactive user interfaces, each must display | ||
| appropriate Legal Notices; however, if the Program has interactive | ||
| interfaces that do not display Appropriate Legal Notices, your | ||
| work need not make them do so. | ||
|
|
||
| A compilation of a covered work with other separate and independent | ||
| works, which are not by their nature extensions of the covered work, | ||
| and which are not combined with it such as to form a larger program, | ||
| in or on a volume of a storage or distribution medium, is called an | ||
| "aggregate" if the compilation and its rights are not summarized to | ||
| permit the group of recipients of the compilation to relicense or | ||
| convey individual copies. Inclusion of a covered work in an aggregate | ||
| does not cause this License to apply to the other parts of the | ||
| aggregate. | ||
|
|
||
| 6. Conveying Non-Source Forms. | ||
|
|
||
| You may convey a covered work in object code form under the terms | ||
| of sections 4 and 5, provided that you also convey the | ||
| machine-readable Corresponding Source under the terms of this License, | ||
| in one of these ways: | ||
|
|
||
| a) Convey the object code in, or embodied in, a physical product | ||
| (including a physical distribution medium), accompanied by the | ||
| Corresponding Source fixed on a durable physical medium | ||
| customarily used for software interchange. | ||
|
|
||
| b) Convey the object code in, or embodied in, a physical product | ||
| (including a physical distribution medium), accompanied by a | ||
| written offer, valid for at least three years and valid for as | ||
| long as you offer spare parts or customer support for that product | ||
| model, to give anyone who possesses the object code either (1) a | ||
| copy of the Corresponding Source for all the software in the | ||
| product that is covered by this License, on a durable physical | ||
| medium customarily used for software interchange, for a price no | ||
| more than your reasonable cost of performing this source | ||
| distribution, or (2) access to copy the | ||
| Corresponding Source from a network server at no charge. | ||
|
|
||
| c) Convey individual copies of the object code with a copy of the | ||
| written offer to provide the Corresponding Source. This | ||
| alternative is allowed only occasionally and noncommercially, and | ||
| only if you received the object code with such an offer, in accord | ||
| with subsection 6b. | ||
|
|
||
| d) If you distribute the object code by offering access from a | ||
| designated place (gratis or for a charge), offer equivalent access | ||
| to copy the Corresponding Source from the same place at no further | ||
| charge. You need not require recipients to copy along with object | ||
| code. If the place to copy object code is a network server, the | ||
| Corresponding Source may be on a different server (that is operated | ||
| by a third party) providing equivalent access, but you must direct | ||
| users to it clearly with prominent notices, and maintain such access | ||
| for as long as you maintain access to the object code. | ||
|
|
||
| e) Verify that the user already has a copy of the Corresponding | ||
| Source for this code, or that you have already sent this copy to this | ||
| user in a single transaction or batch. | ||
|
|
||
| For an executable work, the "Corresponding Source" need not include | ||
| unchanged modules contained in, or merely link with, the executable | ||
| work unless that executable module is, by itself, an executable work. | ||
| When you distribute the same executable with different libraries dynamically | ||
| linked with it, the work must still satisfy this requirement, as long as the | ||
| executable and its Corresponding Source are on the same medium. However, | ||
| this requirement does not apply if the executable links with the | ||
| shared libraries only in the ways that are already permitted under | ||
| this License. | ||
|
|
||
| 7. Additional Terms. | ||
|
|
||
| "Additional permissions" are terms that supplement the terms of this | ||
| License by making exceptions from one or more of its conditions. | ||
| Additional permissions that are applicable to the entire Program shall | ||
| be treated as though they were included in this License, to the extent | ||
| that they are valid under applicable law. If additional permissions | ||
| apply only to part of the Program, that part may be used separately | ||
| under those permissions, but the entire Program remains governed by | ||
| this License without regard to the additional permissions. | ||
|
|
||
| When you convey a copy of a covered work, you may at your option | ||
| remove any additional permissions from that copy, or from any part of | ||
| it. (Additional permissions may be written to require their own | ||
| removal in certain cases when you modify the work.) You may place | ||
| additional permissions on material, added by you to a covered work, | ||
| for which you have or can give appropriate copyright notice. | ||
|
|
||
| Notwithstanding any other provision of this License, for material you | ||
| add to a covered work, you may (if authorized by the copyright holders of | ||
| that material) supplement the terms of this License with terms: | ||
|
|
||
| a) Disclaiming warranty or limiting liability differently from the | ||
| terms of sections 15 and 16 of this License; or | ||
|
|
||
| b) Requiring preservation of specified reasonable legal notices or | ||
| author attributions in that material or in the Appropriate Legal | ||
| Notices displayed by works containing it; or | ||
|
|
||
| c) Prohibiting misrepresentation of the origin of that material, or | ||
| requiring that modified versions of such material be marked in | ||
| reasonable ways as different from the original version; or | ||
|
|
||
| d) Limiting the use for publicity purposes of names of licensors or | ||
| authors of the material; or | ||
|
|
||
| e) Declining to grant rights under trademark law for use of some | ||
| trade names, trademarks, or service marks; or | ||
|
|
||
| f) Requiring indemnification of licensors and authors of that | ||
| material by anyone who conveys the material (or modified versions of | ||
| it) with contractual assumptions of liability to the recipient, for | ||
| any liability that these contractual assumptions directly impose on | ||
| those licensors and authors. | ||
|
|
||
| All other non-permissive additional terms are considered "further | ||
| restrictions" within the meaning of section 10. If the Program as you | ||
| received it, or any part of it, contains a notice stating that it is | ||
| governed by this License along with a term that is a further | ||
| restriction, you may remove that term. If a license document contains | ||
| a further restriction but permits relicensing or conveying under this | ||
| License, you may add to a covered work material governed by the terms | ||
| of that license document, provided that the further restriction does | ||
| not survive such relicensing or conveying. | ||
|
|
||
| If you add terms to a covered work in accord with this section, you | ||
| must also make a statement, in a clear manner at or near the end of the | ||
| copies of these files, of the facts that differentiate your version | ||
| from the original version. | ||
|
|
||
| 8. Limitation of Liability. | ||
|
|
||
| IN NO EVENT UNLESS REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING | ||
| WILL ANY COPYRIGHT HOLDER, OR ANY OTHER PARTY WHO MODIFIES AND/OR CONVEYS | ||
| THE PROGRAM AS PERMITTED ABOVE, BE LIABLE TO YOU FOR DAMAGES, INCLUDING ANY | ||
| GENERAL, SPECIAL, INCIDENTAL OR CONSEQUENTIAL DAMAGES ARISING OUT OF THE | ||
| USE OR INABILITY TO USE THE PROGRAM (INCLUDING BUT NOT LIMITED TO LOSS OF | ||
| DATA OR LOSS OF PROFITS), EVEN IF SUCH HOLDER OR OTHER PARTY HAS BEEN | ||
| ADVISED OF THE POSSIBILITY OF SUCH DAMAGES. |
Contributor
There was a problem hiding this comment.
The license text provided is incomplete and contains structural errors. Specifically, the header for Section 3 is missing, Sections 9 through 15 are entirely absent, and the section labeled '8. Limitation of Liability' actually contains the text for Section 16 of the standard GPLv3. As this is the primary legal document for the project, it should contain the full, unaltered text of the GNU General Public License v3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Updates the project's licensing from the MIT License to the GNU General Public License v3.0 or later. This change ensures that the software remains free and open-source under the terms of the GPL.
Changes
Testing