Skip to content

Fix/calendar load#2091

Merged
seferturan merged 2 commits into
mainfrom
fix/calendar_load
Apr 13, 2026
Merged

Fix/calendar load#2091
seferturan merged 2 commits into
mainfrom
fix/calendar_load

Conversation

@seferturan
Copy link
Copy Markdown
Contributor

🎶 Notes 🎶

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where the calendar loading mechanism would prematurely stop loading after encountering five empty periods. By ensuring the counter for consecutive empty periods is reset when an existing period is updated with content, the system can now correctly continue loading subsequent periods.

Highlights

  • Calendar Loading Logic: Updated the calendar accumulator to correctly reset the consecutive empty periods count when an existing period is updated with new data.
  • Test Coverage: Added new test cases to verify that the empty period counter resets when data is added and remains unchanged if the period stays empty.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@trakt-bot trakt-bot Bot enabled auto-merge (rebase) April 13, 2026 20:17
@deepsource-io
Copy link
Copy Markdown

deepsource-io Bot commented Apr 13, 2026

DeepSource Code Review

We reviewed changes in 64ece82...2eee4ea on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Coverage  

Code Review Summary

Analyzer Status Updated (UTC) Details
JavaScript Apr 13, 2026 8:21p.m. Review ↗
Test coverage Apr 13, 2026 8:21p.m. Review ↗

Code Coverage Summary

Language Line Coverage (Overall)
Aggregate
82.1%
Javascript
82.1%

➟ Additional coverage metrics may have been reported. See full coverage report ↗


Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the calendar accumulator logic to correctly reset the consecutive empty periods counter when an existing period is updated with data. It also includes new test cases to verify this behavior. A suggestion was made to simplify the conditional logic for updating the period count and resetting the counter to improve readability and consistency.

Comment thread projects/client/src/lib/features/calendar/_internal/createCalendarAccumulator.ts Outdated
@seferturan seferturan requested a review from vladjerca April 13, 2026 20:24
@seferturan seferturan disabled auto-merge April 13, 2026 20:24
@seferturan seferturan merged commit f499a0e into main Apr 13, 2026
18 checks passed
@seferturan seferturan deleted the fix/calendar_load branch April 13, 2026 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Calendar lazy load always stops after 5 periods

1 participant