Skip to content

feat(navbar): adds support for expanding side bar#2101

Merged
trakt-bot[bot] merged 1 commit into
mainfrom
feat/expanded_sidebar
Apr 14, 2026
Merged

feat(navbar): adds support for expanding side bar#2101
trakt-bot[bot] merged 1 commit into
mainfrom
feat/expanded_sidebar

Conversation

@seferturan
Copy link
Copy Markdown
Contributor

🎶 Notes 🎶

⚠️ Caveat ⚠️

In the collapsed state, the trakt logo is not visible. I experimented with putting in the actions bar, but that looked crappy:
Screenshot 2026-04-14 at 10 17 24

Either we leave it without the logo, or we do a follow-up with a better solution😅

👀 Example 👀

Screen.Recording.2026-04-14.at.10.42.21.mov

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces an expandable side navigation bar, providing users with the flexibility to switch between a compact icon-only view and an expanded view with labels. The changes involve significant refactoring of the navbar structure to support dynamic width adjustments and state management, ensuring a seamless transition between the two modes while maintaining existing functionality.

Highlights

  • Side Navbar Expansion: Implemented a toggle mechanism to expand and collapse the side navigation bar, allowing for a more compact or detailed view.
  • UI Components: Added a new MenuIcon component and refactored existing navbar components to support the new expanded state, including updated layouts for user menus and navigation groups.
  • Tooltip Enhancements: Updated the Tooltip component to support a disabled state, which is utilized when the navbar is expanded to prevent redundant tooltips.
  • Localization: Added new translation keys for the expand and collapse button labels.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@trakt-bot trakt-bot Bot enabled auto-merge (rebase) April 14, 2026 08:50
@deepsource-io
Copy link
Copy Markdown

deepsource-io Bot commented Apr 14, 2026

DeepSource Code Review

We reviewed changes in 1674ccb...621b5f3 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Coverage  

Code Review Summary

Analyzer Status Updated (UTC) Details
JavaScript Apr 14, 2026 9:02a.m. Review ↗
Code coverage Apr 14, 2026 9:02a.m. Review ↗

Code Coverage Summary

Language Line Coverage (Overall)
Aggregate
82.1%
Javascript
82.1%

➟ Additional coverage metrics may have been reported. See full coverage report ↗


Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements a collapsible side navigation bar, introducing a new MenuIcon component and refactoring the SideNavbar to support both expanded and collapsed states via the useCollapsedSection store. The changes include extracting logic into internal components like NavGroup and SideNavbarContent, adding a disabled prop to Tooltips, and updating the UserMenu and ProfileLink to display labels when expanded. Feedback suggests adhering to Svelte 5 best practices by using reactive style declarations instead of $effect for document-level CSS variables, as well as improving CSS maintainability by replacing implicit variables with explicit props for alignment and simplifying absolute positioning in the user menu.

Comment thread projects/client/src/lib/sections/navbar/SideNavbar.svelte
Comment thread projects/client/src/lib/sections/navbar/_internal/NavGroup.svelte Outdated
Comment thread projects/client/src/lib/sections/navbar/components/UserMenu.svelte
@seferturan seferturan force-pushed the feat/expanded_sidebar branch from d83385e to 621b5f3 Compare April 14, 2026 09:02
@seferturan seferturan requested a review from vladjerca April 14, 2026 09:09
@trakt-bot trakt-bot Bot merged commit 5a151ac into main Apr 14, 2026
28 of 29 checks passed
@trakt-bot trakt-bot Bot deleted the feat/expanded_sidebar branch April 14, 2026 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for expanding sidenavbar

2 participants