Add support for Tarchives over REST interface (#35)#37
Merged
Conversation
traktion
commented
Jan 20, 2026
| } | ||
|
|
||
| // Generate and append index | ||
| self.append_index(&tar_path)?; |
Owner
Author
There was a problem hiding this comment.
There seems to be a bug/limitation in the tar library, where appending doesn't seem to work as expected.
I experimented with this issue last night and it looks like excessive padding between the current and appended files.
Happy to merge for now, as the shape looks correct. However, the issue will need to be resolved in a future task.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #35.
This PR adds support for creating and updating Tarchives via the REST interface.
Changes:
Tarchivemodel insrc/model/tarchive.rsfor indexing logic (ported fromtarindexer.py).TarchiveServiceinsrc/service/tarchive_service.rsto handle multipart uploads, tar file generation, and appending indices.src/controller/tarchive_controller.rs(POST /anttp-0/multipart/tarchiveandPUT /anttp-0/multipart/tarchive/{address}).src/lib.rsand updated OpenAPI documentation.0.23.7.