chore: issue forms with reason-listings#3476
Merged
Merged
Conversation
CommanderStorm
changed the title
abonander
requested changes
Sep 4, 2024
Comment on lines
+31
to
+36
| value: | | ||
| * SQLx version: [REQUIRED] | ||
| * SQLx features enabled: [REQUIRED] | ||
| * Database server and version: [REQUIRED] (MySQL / Postgres / SQLite <x.y.z>) | ||
| * Operating system: [REQUIRED] | ||
| * `rustc --version`: [REQUIRED] |
Collaborator
There was a problem hiding this comment.
Might as well break these out into separate fields.
Contributor
Author
There was a problem hiding this comment.
Fair enough.
This has the downside of looking a bit longer in the issue that is genereated, but that is likely an ok downside
Contributor
Author
|
Being upfront: Sorry, hope that does not bother you too much |
Co-authored-by: Austin Bonander <austin.bonander@gmail.com>
Co-authored-by: Austin Bonander <austin.bonander@gmail.com>
Collaborator
|
I neglected this for a bit, sorry. I think this is an improvement over the existing forms, we can iterate as things come up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does your PR solve an issue?
As discussed in #3471, I have added a field to the form.
I have also migrated to using issue-forms as they are a bit better too fill out and users are less likely to flat-out ignore the form.
You can preview it here: