Added missing special casing for encoding embedded arrays of custom types#3603
Merged
abonander merged 3 commits intoJan 28, 2025
Merged
Conversation
12b29d9 to
d6390d5
Compare
abonander
approved these changes
Jan 25, 2025
d6390d5 to
53d30f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1672 - or at least my last comment on the ticket, as I now realise the person originally reported a decoding issue, and this is about encoding, as decoding already worked fine. My specific scenario has been added to the test suite to confirm this fixes it.
This fix is inspired by this similar bit of code:
https://github.com/launchbadge/sqlx/blob/82d332f4b487440b4c2bd5d54a5f17dcc1abc92c/sqlx-postgres/src/types/array.rs#L168-L175
With this fix in, it's now perfectly fine to store (and retrieve) nested structures in Postgres, without any additional boilerplate, such as:
By the way, I've seen comments pointing to using the newtype pattern to map embedded arrays of custom types; but it's no longer necessary after this fix, so it might be worth updating the official documentation with an example.