fix: executor arg of RawSql methods can have looser bound#3656
Closed
tisonkun wants to merge 2 commits into
Closed
fix: executor arg of RawSql methods can have looser bound#3656tisonkun wants to merge 2 commits into
tisonkun wants to merge 2 commits into
Conversation
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Contributor
Author
|
I just find that the implementation of |
Contributor
|
Looks like there is already a fix for this (#3613) |
Contributor
Author
|
@joeydewaal Looks correct. I'd leave to @abonander to manage both PRs. Closing this is fine. |
Collaborator
|
I believe I tried this approach and it didn't fix the minimal reproduction I came up with. Since this doesn't have a reproduction to show that it fixes the problem, and my PR makes the API match the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original code has an unnecessary lifetime bound
'q: 'e.We have a code snippet like:
failed with:
implementation of `std::marker::Send` is not general enoughin several caller layers outside.while change to:
works.
A brief is that the
txn's lifetime bound to the outer struct, so as long as the returned future is bound to that lifetime, rustc knows it's send for all outer struct's lifetime.However, with
.execute(&mut **txn), the new lifetimecis resolved toewhere'q: 'eand then the return future lifetime is'e. Now rustc doesn't know the relation of the lifetimes, and failed to compile.