fix: use Executor::fetch in QueryAs::fetch#3886
Merged
Merged
Conversation
bobozaur
force-pushed
the
fix_query_as_fetch
branch
from
c73c29a to
76274cc
Compare
bobozaur
force-pushed
the
fix_query_as_fetch
branch
from
76274cc to
4b32c8f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does your PR solve an issue?
Not that I could find. Though it addresses a
FIXMEcomment in the code.Is this a breaking change?
It is a breaking change, though this seems like it was an oversight which has been lingering along the codebase. The
QueryAs::fetchmethod was probably never intended to allow multi-statement queries. Doing this now since0.9.0seems to be the nextSQLxversion.