Replace Markdown Editor with MDXEditor for Experiment Notes#2008
Merged
Conversation
Swap out the TipTap-based editor in ExperimentNotes for MDXEditor, which provides a built-in toolbar with rich-text/source view toggle and handles image upload via a configurable handler. Removes the now-unused @tiptap/* and tiptap-markdown dependencies.
✅ Deploy Preview for transformerlab canceled.
|
|
Paragon Review Skipped Hi @aliasaria! Your Polarity credit balance is insufficient to complete this review. Please visit https://app.paragon.run to finish your review. |
aliasaria
changed the title
deep1401
requested changes
May 6, 2026
Member
deep1401
left a comment
deep1401
left a comment
There was a problem hiding this comment.
Adding an image when I have remote storage enabled appears like this when I revisit notes:
deep1401
approved these changes
May 6, 2026
Member
deep1401
left a comment
deep1401
left a comment
There was a problem hiding this comment.
Okay I fixed the image upload issue. Also fixed the issue where uploading another image with the same name was overwriting the existing one
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ExperimentNotesfor MDXEditor, with a toolbar (headings, bold/italic, lists, links, images, thematic break) and a rich-text ↔ source toggle.imagePluginimageUploadHandler, which the toolbar'sInsertImagebutton and paste/drop both go through. Removes the now-redundant external "Upload Image" button.Test plan
imageUploadHandler.notes/assets/<file>on save and re-inflated to fully-qualified URLs on load.