Skip to content

Conversation

@deep1401
Copy link
Member

@deep1401 deep1401 commented Dec 1, 2025

  • Change behaviour of TFL_API_STORAGE_URI to be a true/false flag such that if set, then creating a new team would create a new bucket and use that bucket for operations in transformer lab related to workspace
  • Enable releases of lab sdk on merges to main rather than only on a release.
  • The credentials are assumed to be under the AWS profile transformerlab-s3 and will be taken from there

@codecov-commenter
Copy link

Copy link
Member Author

@deep1401 deep1401 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dadmobile For whenever you review this, the failing tests are only because the sdk version is also being incremented and the release is not out yet. I undid this in the commit 6702035 and the tests passed. I just restored the version in the commit after that

@mina-parham
Copy link
Contributor

I was testing this PR and it's working on my side perfectly, also fix the stream log issue.

@dadmobile
Copy link
Member

My API said this:

boto3 is not installed. Cannot create S3 bucket.

But then it definitely created the bucket?!?

Created directory for Experiment with id 'alpha'
👀 Watching S3 file: s3://workspace-ee7187ea-7fe6-4712-a4d0-d82f4d63fffa/transformerlab.log

@dadmobile
Copy link
Member

My API said this:

boto3 is not installed. Cannot create S3 bucket.

But then it definitely created the bucket?!?

Created directory for Experiment with id 'alpha'
👀 Watching S3 file: s3://workspace-ee7187ea-7fe6-4712-a4d0-d82f4d63fffa/transformerlab.log

Oh never mind...my requirements didn't update!

Copy link
Member

@dadmobile dadmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK so I get why pytest and the build are failing (because this PR contains a self-referential SDK build). But do you know why ruff is failing?

@deep1401
Copy link
Member Author

deep1401 commented Dec 3, 2025

OK so I get why pytest and the build are failing (because this PR contains a self-referential SDK build). But do you know why ruff is failing?

Oh I think the ruff is failing because of the new rules, let me fix that. I did all the pushes before ruff.toml

@deep1401 deep1401 merged commit 7a42328 into main Dec 3, 2025
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants