-
-
Notifications
You must be signed in to change notification settings - Fork 468
Add automatic bucket creation logic #977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… using that bucket for workspace when TFL_API_STORAGE_URI is set
…ab-app into add/bucket-creation-logix
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
deep1401
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dadmobile For whenever you review this, the failing tests are only because the sdk version is also being incremented and the release is not out yet. I undid this in the commit 6702035 and the tests passed. I just restored the version in the commit after that
|
I was testing this PR and it's working on my side perfectly, also fix the stream log issue. |
|
My API said this:
But then it definitely created the bucket?!? |
Oh never mind...my requirements didn't update! |
dadmobile
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK so I get why pytest and the build are failing (because this PR contains a self-referential SDK build). But do you know why ruff is failing?
Oh I think the ruff is failing because of the new rules, let me fix that. I did all the pushes before ruff.toml |
TFL_API_STORAGE_URIto be a true/false flag such that if set, then creating a new team would create a new bucket and use that bucket for operations in transformer lab related to workspacetransformerlab-s3and will be taken from there