Fix video and audio going out of sync #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rikhuijzer
changed the title
rikhuijzer
added a commit
that referenced
this pull request
Mar 12, 2025
Fixes #34. This seems to work great. CI running times are halved and when generating subtitles on a video that has 20 slides and takes multiple minutes all subtitles remain in sync for the duration of the video (related to #25) 🚀. This is an example of the command that the code generates: ```sh $ ffmpeg \ -i _out/audio/1.wav \ -loop 1 -framerate 1 -t "00:00:04.93" -i _out/image/1.png \ -i _out/audio/2.wav \ -loop 1 -framerate 1 -t "00:00:07.48" -i _out/image/2.png \ -filter_complex \ " [1:v]scale=-1:1080,format=yuv420p[v0]; \ [3:v]scale=-1:1080,format=yuv420p[v1]; \ [v0][0:a][v1][2:a] concat=n=2:v=1:a=1 [outv] [outa] \ " \ -map "[outv]" -r 30 -map "[outa]" -tune stillimage \ -c:a opus \ -strict -2 \ -shortest \ -movflags \ +faststart \ _out/out.mp4 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This problem might have been there since the start, but I only noticed it with a longer video. With longer videos, subtitles generated with whisper were going out of sync. The problem was that mp3 files were shorter than the original mp4 files due to encoding differences.
Closes #24.