Skip to content

Migrate CI to GitHub Actions#42

Merged
n1k0sv merged 1 commit intodevelfrom
github-actions
Jan 29, 2021
Merged

Migrate CI to GitHub Actions#42
n1k0sv merged 1 commit intodevelfrom
github-actions

Conversation

@n1k0sv
Copy link
Copy Markdown

@n1k0sv n1k0sv commented Jan 28, 2021

No description provided.

@n1k0sv n1k0sv force-pushed the github-actions branch 2 times, most recently from 27db03f to d16bd48 Compare January 28, 2021 14:53
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 28, 2021

Codecov Report

Merging #42 (c3fc801) into devel (855eeb1) will increase coverage by 0.13%.
The diff coverage is 95.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel      #42      +/-   ##
==========================================
+ Coverage   76.61%   76.75%   +0.13%     
==========================================
  Files          33       33              
  Lines        2613     2667      +54     
==========================================
+ Hits         2002     2047      +45     
- Misses        611      620       +9     
Impacted Files Coverage Δ
transifex/common/console.py 77.77% <ø> (ø)
transifex/native/django/utils/__init__.py 91.66% <75.00%> (ø)
transifex/native/django/utils/templates.py 96.07% <75.00%> (+0.07%) ⬆️
transifex/common/utils.py 97.75% <89.47%> (-2.25%) ⬇️
transifex/native/cds.py 97.84% <100.00%> (+0.14%) ⬆️
transifex/native/core.py 100.00% <100.00%> (ø)
transifex/native/django/management/common.py 86.66% <100.00%> (ø)
...ransifex/native/django/management/utils/migrate.py 95.23% <100.00%> (+0.79%) ⬆️
transifex/native/django/management/utils/push.py 100.00% <100.00%> (ø)
transifex/native/django/templatetags/transifex.py 95.78% <100.00%> (+0.09%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e428f58...c3fc801. Read the comment docs.

@n1k0sv n1k0sv requested a review from kbairak January 29, 2021 08:43
Copy link
Copy Markdown

@kbairak kbairak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and works great. Publishing to PyPI remains to be seen, but I have no reason to believe it won't work.

I have a suggestion for when we have time to experiment.

We can use docker save and docker load to save and load docker images to tar archives and use workflow artifacts to share them between the jobs of the github action. This way, we won't have to rebuild the images for code checks and test runs.

@n1k0sv n1k0sv merged commit f6744fc into devel Jan 29, 2021
@n1k0sv n1k0sv deleted the github-actions branch January 29, 2021 10:24
Comment thread .github/workflows/ci.yml
docker build --build-arg PYTHON_VERSION=2.7 --build-arg DJANGO_VERSION=1.11 -t native -f Dockerfile-tmpl .
docker run -e CODECOV_TOKEN=$CODECOV_TOKEN --rm native sh -c 'pytest --cov --cov-report=term-missing && codecov'
env:
CODECOV_TOKEN: ${{secrets.codecov_token}}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason this is lowercase but {{secrets.PYPI_API_TOKEN}} below is uppercase?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants