Conversation
27db03f to
d16bd48
Compare
Codecov Report
@@ Coverage Diff @@
## devel #42 +/- ##
==========================================
+ Coverage 76.61% 76.75% +0.13%
==========================================
Files 33 33
Lines 2613 2667 +54
==========================================
+ Hits 2002 2047 +45
- Misses 611 620 +9
Continue to review full report at Codecov.
|
cbb43f8 to
96c8cdf
Compare
96c8cdf to
c3fc801
Compare
kbairak
left a comment
There was a problem hiding this comment.
Looks great and works great. Publishing to PyPI remains to be seen, but I have no reason to believe it won't work.
I have a suggestion for when we have time to experiment.
We can use docker save and docker load to save and load docker images to tar archives and use workflow artifacts to share them between the jobs of the github action. This way, we won't have to rebuild the images for code checks and test runs.
| docker build --build-arg PYTHON_VERSION=2.7 --build-arg DJANGO_VERSION=1.11 -t native -f Dockerfile-tmpl . | ||
| docker run -e CODECOV_TOKEN=$CODECOV_TOKEN --rm native sh -c 'pytest --cov --cov-report=term-missing && codecov' | ||
| env: | ||
| CODECOV_TOKEN: ${{secrets.codecov_token}} |
There was a problem hiding this comment.
Any reason this is lowercase but {{secrets.PYPI_API_TOKEN}} below is uppercase?
No description provided.