Containerize NTT #90
Containerize NTT #90
Conversation
|
@mathcolo Let's throw some README updates in as well for the people (it's me, I'm the people) |
mathcolo
changed the title
|
I think this is almost good to go! @Joshhw we just need to hook up the host's MBTA API key (ideally). I can cover that unless you beat me to it |
|
this should be R4R. I need some folks to test it out. |
|
I was playing around with the Steps (on latest commit - 8ca1522):
Log: ** Edit ** |
|
@Joshhw Do you want to address @thiteixeira feedback or me? I know I originally filed this, but I don't want to steal your thunder. |
Co-authored-by: Thiago Teixeira <thiteixeira@gmail.com>
|
I'm happy to give this PR a try as well |
|
Ok, I think I've fixed most things. I noticed the listing jobs kept failing as it was hoping to find react 17 rather than react 18. I also added another peer dep as well. Please someone test this out. |
thiteixeira
left a comment
thiteixeira
left a comment
There was a problem hiding this comment.
Great work! Just a comment on the react types version, but otherwise it looks great
Co-authored-by: Thiago Teixeira <thiteixeira@gmail.com>
|
Do I need anyone else to approve this? |
|
@mathcolo can't technically approve since he created the PR, but maybe a written approval? |
idreyn
left a comment
idreyn
left a comment
There was a problem hiding this comment.
This looks good (actually, so cool) to me. This is more Docker than I've ever seen, so I'm mostly approving on pure enthusiasm.
Should we update the README with new local build instructions (here or in a follow-up PR?)
|
I can update the README on my PR (#99) if you like so we get this in |
mathcolo
left a comment
mathcolo
left a comment
There was a problem hiding this comment.
I think we should wait on merging this until we resolve the React 18 incompatibility
should be good now. I honestly don't know why I had issues initially but it seems to be fine after updating the versions. |
* container WIP * add preliminary proposal * address most pr comments * functional docker-compose setup * removes depends_on cause v3 doesn't use it * remove os import as its unused * remove favicon dependency and update extension to .ico * mostly functional now * adds script for building * fixes db host and removes it to local env for docker image * removes unneeded code * Install poetry instead of pipenv * trying new config * remove extra space in util.py * Update server/history/util.py Co-authored-by: Thiago Teixeira <thiteixeira@gmail.com> * updates poetry requirements and some dockerfile stuff along with the lock file * new version who dis * fix localhost to 0.0.0.0 for the gunicorn app * testing this change * Update package.json Co-authored-by: Thiago Teixeira <thiteixeira@gmail.com> * testing new package lock * update react versions * fix patch version * Revert "Revert "Containerize NTT (#90)"" This reverts commit 7ff758f. * Updating static data and display updated date * adding api call * modify line stats based on available data * revert some changes * bring back static data * some change * match branch with master * forgot package-lock * remove console statements * Update static file * Using static data again * Resolve json in typescript * Train cars not Trains --------- Co-authored-by: Preston Mueller <skierjunk@gmail.com> Co-authored-by: Joshua Decosta <josh@Joshuas-M1.lan> Co-authored-by: Joshua Decosta <joshdecosta@gmail.com> Co-authored-by: Devin Matte <devinmatte@gmail.com>
Almost works except that DNS lookup in the NTT container cannot find the postgres container for some reason!
It's probably something stupid I'm missing
help