Add method for generating signed Smart CDN URLs#92
Merged
Conversation
added 2 commits
November 22, 2024 15:21
Contributor
Author
|
@cdr-chakotay Can you help me fix this linting error? https://github.com/transloadit/java-sdk/actions/runs/11974368156/job/33385298147#step:4:388 |
Contributor
Sure! Will send you changes to circumvent this. (Need to get them uploaded from my IDE) |
…-sdk into smart-cdn-url-signature # Conflicts: # src/main/java/com/transloadit/sdk/Transloadit.java
…-sdk into smart-cdn-url-signature
cdr-chakotay
approved these changes
Nov 25, 2024
Contributor
cdr-chakotay
left a comment
cdr-chakotay
left a comment
There was a problem hiding this comment.
I did now push the pending changes directly to circumvent the extra work:
- replaced wildcard imports
- dealt with trailing spaces
- dealt with line length issues
Contributor
Author
|
Thank you very much! |
added 2 commits
November 28, 2024 11:41
…dit/java-sdk into smart-cdn-url-signature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We recently added support for signed Smart CDN URLs (see https://transloadit.com/docs/topics/signature-authentication/#smart-cdn) and would like our SDKs to offer methods for generating these signed URLs.
This PR adds such a method with tests.