fix: avoid nodejs stream namespace leak#132
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The all-packages consumer smoke showed that runtime installs work, but
@transloadit/sev-loggerstill leakedNodeJS.WriteStreamthrough its public declarations. That makes TypeScript consumers depend on a globalNodeJSnamespace even when they only need the logger's stream contract.What changed
SevLoggerStreaminterface for the logger's stdout/stderr options and properties.SevLoggerStreamfrom the package root.@transloadit/sev-loggerto1.0.2with a changelog entry.Verification
corepack yarn install --immutablecorepack yarn dedupe --checkcorepack yarn checkcorepack yarn npm audit --recursive --allgit diff --check@types/node