fix: respect no color for inspected values#133
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Running the full
SevLogger.playground.tsas an npm consumer from/tmp/fooworked, but showed one polish bug:NO_COLOR=1disabled logger colors while inspected object values still emitted ANSI escape codes.What changed
NO_COLOR=1.NO_COLOR=1.@transloadit/sev-loggerto1.0.3with a changelog entry.Verification
corepack yarn install --immutablecorepack yarn dedupe --checkcorepack yarn checkcorepack yarn npm audit --recursive --allgit diff --check/tmp/foonpm-consumer playground run against@transloadit/sev-logger@1.0.2before the fix