Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f931dde261
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| if (this.getIntentDefinition().outputMode === 'directory') { | ||
| return join(dirname(inputPath), parse(inputPath).name) | ||
| } |
There was a problem hiding this comment.
Prevent inferred directory output from reusing input file path
For directory-output intents, getSiblingOutputPath always returns join(dirname(inputPath), parse(inputPath).name), which can resolve to the same path as the input file (for extensionless inputs like /tmp/report) or another existing file with the same basename. When --output is omitted, this inferred path is passed as a directory target and later fails in assemblies.create with “Output must be a directory for this command”, so valid single-file runs unexpectedly error instead of choosing a safe fallback path.
Useful? React with 👍 / 👎.
Summary
--output, -oinstead of--out--outputis omittedTesting