Skip to content

chore: updating supported python versions#29

Merged
cdr-chakotay merged 8 commits intotransloadit:mainfrom
Artui:chore/python-update
Jul 16, 2024
Merged

chore: updating supported python versions#29
cdr-chakotay merged 8 commits intotransloadit:mainfrom
Artui:chore/python-update

Conversation

@Artui
Copy link
Copy Markdown
Contributor

@Artui Artui commented Jun 20, 2024

Addresses #28 issue

@kvz
Copy link
Copy Markdown
Member

kvz commented Jun 20, 2024

Sadly the build failed. I’m not deep into python and could signal a maintainer but perhaps you can see what’s the trouble?

perhaps the version was limited for a good reason 🤔

@Artui
Copy link
Copy Markdown
Contributor Author

Artui commented Jun 20, 2024

Sadly the build failed. I’m not deep into python and could signal a maintainer but perhaps you can see what’s the trouble?

perhaps the version was limited for a good reason 🤔

One of the dependencies with the current version works for python 3.7, but doesn't work for 3.12. If I update it to the version that supports 3.12, we lose support for 3.7 :D
I wonder if we're okay with losing support for 3.7?

@Acconut
Copy link
Copy Markdown
Contributor

Acconut commented Jun 21, 2024

We're fine with dropping support for older Python release, but that has to part of a major release as it's a breaking change. I don't see any reason against a major release, but we might want to use this opportunity to also drop 3.8, whose support ends in November 2024: https://devguide.python.org/versions/

@Artui
Copy link
Copy Markdown
Contributor Author

Artui commented Jun 21, 2024

We're fine with dropping support for older Python release, but that has to part of a major release as it's a breaking change. I don't see any reason against a major release, but we might want to use this opportunity to also drop 3.8, whose support ends in November 2024: https://devguide.python.org/versions/

I'm down for that! Added this to the PR :)

@Artui
Copy link
Copy Markdown
Contributor Author

Artui commented Jun 21, 2024

Also updated version to 0.3.0, not sure if we want to do 1.x.x, since the version was 0.2.2 before my PR

@kvz
Copy link
Copy Markdown
Member

kvz commented Jun 21, 2024

When cutting major releases, I think we have to involve the experts, @arnaudlimbourg & @ifedapoolarewaj.

do we see other opportunities for upgrades that are breaking, that we should be making in this release?

@Acconut
Copy link
Copy Markdown
Contributor

Acconut commented Jun 21, 2024

You misspelled @ifedapoolarewaju :)

@Acconut
Copy link
Copy Markdown
Contributor

Acconut commented Jun 21, 2024

Also updated version to 0.3.0, not sure if we want to do 1.x.x, since the version was 0.2.2 before my PR

If we do a major release, it will be 1.0.0

@Artui
Copy link
Copy Markdown
Contributor Author

Artui commented Jun 21, 2024

Also updated version to 0.3.0, not sure if we want to do 1.x.x, since the version was 0.2.2 before my PR

If we do a major release, it will be 1.0.0

Sure, it's just been in 0.x.x for a while, just wanted to check in if it's ready for 1.0.0

@Artui
Copy link
Copy Markdown
Contributor Author

Artui commented Jun 25, 2024

Any updates on the status here? @kvz @arnaudlimbourg @ifedapoolarewaju

@ifedapoolarewaju
Copy link
Copy Markdown
Collaborator

Hi, I just realised that we need to update the version variable as well. Otherwise the SDK will be sending the wrong version to Transloadit servers.

When we do that, we'd need to update this line in the test so it passes

@Artui
Copy link
Copy Markdown
Contributor Author

Artui commented Jul 1, 2024

Hi, I just realised that we need to update the version variable as well. Otherwise the SDK will be sending the wrong version to Transloadit servers.

When we do that, we'd need to update this line in the test so it passes

Thanks! Updated

@Artui
Copy link
Copy Markdown
Contributor Author

Artui commented Jul 9, 2024

Pinging once more, just to check in :)
@ifedapoolarewaju @arnaudlimbourg

@Artui
Copy link
Copy Markdown
Contributor Author

Artui commented Jul 10, 2024

I see that all the tests have passed now, thanks for approving the pipeline. How long would it take to get a release out there? I don't see a PyPi deployment piece in the Github Actions code, so I assume it's a manual process done by one of the maintainers?

Comment thread pyproject.toml Outdated
@ifedapoolarewaju
Copy link
Copy Markdown
Collaborator

This looks all good to me.
@kvz @Acconut would there be any other objections to merging this?

Copy link
Copy Markdown
Contributor

@Acconut Acconut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the feedback!

@Artui
Copy link
Copy Markdown
Contributor Author

Artui commented Jul 10, 2024

Awesome, thanks!

@Acconut
Copy link
Copy Markdown
Contributor

Acconut commented Jul 11, 2024

One more thing: Can you please update the README? It currently says:

Only Python 3.7+ versions are supported.

@Artui
Copy link
Copy Markdown
Contributor Author

Artui commented Jul 12, 2024

@Acconut I've updated that and updated CHANGELOG as well.
Can you merge it and push the new version to PyPi?

Copy link
Copy Markdown
Contributor

@Acconut Acconut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cdr-chakotay Could you merge and release this PR?

@cdr-chakotay
Copy link
Copy Markdown
Contributor

cdr-chakotay commented Jul 15, 2024

@cdr-chakotay Could you merge and release this PR?

Sure, we have had some internal discussions on further release.
I am not 100% convinced with the major version.
Will come back to you :)

@cdr-chakotay cdr-chakotay merged commit a124bcd into transloadit:main Jul 16, 2024
@cdr-chakotay
Copy link
Copy Markdown
Contributor

@Artui Merged this one and will release soon. Thanks for your contribution!

@Artui Artui deleted the chore/python-update branch July 16, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants