chore: updating supported python versions#29
Conversation
|
Sadly the build failed. I’m not deep into python and could signal a maintainer but perhaps you can see what’s the trouble? perhaps the version was limited for a good reason 🤔 |
One of the dependencies with the current version works for python 3.7, but doesn't work for 3.12. If I update it to the version that supports 3.12, we lose support for 3.7 :D |
|
We're fine with dropping support for older Python release, but that has to part of a major release as it's a breaking change. I don't see any reason against a major release, but we might want to use this opportunity to also drop 3.8, whose support ends in November 2024: https://devguide.python.org/versions/ |
I'm down for that! Added this to the PR :) |
|
Also updated version to 0.3.0, not sure if we want to do 1.x.x, since the version was 0.2.2 before my PR |
|
When cutting major releases, I think we have to involve the experts, @arnaudlimbourg & @ifedapoolarewaj. do we see other opportunities for upgrades that are breaking, that we should be making in this release? |
|
You misspelled @ifedapoolarewaju :) |
If we do a major release, it will be 1.0.0 |
Sure, it's just been in 0.x.x for a while, just wanted to check in if it's ready for 1.0.0 |
|
Any updates on the status here? @kvz @arnaudlimbourg @ifedapoolarewaju |
|
Pinging once more, just to check in :) |
|
I see that all the tests have passed now, thanks for approving the pipeline. How long would it take to get a release out there? I don't see a PyPi deployment piece in the Github Actions code, so I assume it's a manual process done by one of the maintainers? |
Acconut
left a comment
There was a problem hiding this comment.
Looks good, thanks for the feedback!
|
Awesome, thanks! |
|
One more thing: Can you please update the README? It currently says:
|
|
@Acconut I've updated that and updated CHANGELOG as well. |
Acconut
left a comment
There was a problem hiding this comment.
@cdr-chakotay Could you merge and release this PR?
Sure, we have had some internal discussions on further release. |
|
@Artui Merged this one and will release soon. Thanks for your contribution! |
Addresses #28 issue