Move preview revocation to thumbnail-generator#1090
Merged
Conversation
Contributor
Tested by adding a bunch of files, then pressed “cancel” (which calls
Is that because those were already in progress, and not in a queue? 🤔 |
Contributor
Author
|
Hmm, I get the same behaviour without this patch (only for one thumbnail file though),
This sounds the most likely scenario to me. Actually, that code is not touched by this PR, so scratch the above heh. |
Contributor
|
Merging already 👌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a little clearer than doing it in core.
It now also deals with files being removed while a thumbnail generation job is still in the queue.