S3 multipart: Do not store completed parts in state#2326
Merged
Conversation
…3 and do not need to be stored locally (alternative fix to transloadit#2324)
Contributor
Author
|
From what I see, storing the parts in the state is not necessary, as when the upload is restarted, the plugin queries already uploaded parts via S3 API and fills the actual parts (see MultipartUploader._resumeUpload). This might be a better fix for #2324 (than #2325 which I originally submitted) as it eliminates the duplicating structures all together. |
goto-bus-stop
approved these changes
Jun 22, 2020
Contributor
goto-bus-stop
left a comment
goto-bus-stop
left a comment
There was a problem hiding this comment.
Thank you, I think you're right!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not store completed parts in state as they can be retrieved from S3 and do not need to be stored locally (this also fixes #2324)
closes #2325