Skip to content

Allow passing on XHRUpload options, such as "limit" to AwsS3 Plugin#471

Merged
goto-bus-stop merged 3 commits into
transloadit:masterfrom
ogtfaber:master
Dec 29, 2017
Merged

Allow passing on XHRUpload options, such as "limit" to AwsS3 Plugin#471
goto-bus-stop merged 3 commits into
transloadit:masterfrom
ogtfaber:master

Conversation

@ogtfaber
Copy link
Copy Markdown
Contributor

I need this option to keep large amount of uploads working: #468

@goto-bus-stop
Copy link
Copy Markdown
Contributor

thanks! i worry that a xhrOptions option makes the abstraction a bit leaky--it would be nice if the user never had to know that XHRUpload is being used internally. (and in the future, we might teach the AwsS3 plugin to use 'multipart' uploads for large files, which wouldn't be able to defer to the XHRUpload plugin). perhaps we could take a limit option like .use(AwsS3, { limit: 10 }) instead and just pass that through? what's your thoughts on that?

@ogtfaber
Copy link
Copy Markdown
Contributor Author

@goto-bus-stop that makes sense. There's still more work to do since (as you know ;-) the "limit" option does not work well with the plugins currently.

@ogtfaber
Copy link
Copy Markdown
Contributor Author

@goto-bus-stop how about this

@goto-bus-stop
Copy link
Copy Markdown
Contributor

yeah this is perfect, thanks! good call on adding timeout too. we'll have to address the problems with limit in the new year i suppose :)

@goto-bus-stop goto-bus-stop merged commit 8235ae0 into transloadit:master Dec 29, 2017
@ogtfaber
Copy link
Copy Markdown
Contributor Author

ogtfaber commented Jan 1, 2018

Awesome, thanks @goto-bus-stop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants