You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
thanks! i worry that a xhrOptions option makes the abstraction a bit leaky--it would be nice if the user never had to know that XHRUpload is being used internally. (and in the future, we might teach the AwsS3 plugin to use 'multipart' uploads for large files, which wouldn't be able to defer to the XHRUpload plugin). perhaps we could take a limit option like .use(AwsS3, { limit: 10 }) instead and just pass that through? what's your thoughts on that?
@goto-bus-stop that makes sense. There's still more work to do since (as you know ;-) the "limit" option does not work well with the plugins currently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I need this option to keep large amount of uploads working: #468