Win32: check for bcrypt.lib#6
Closed
Coeur wants to merge 3 commits intotransmission:masterfrom
Closed
Conversation
|
@Coeur: Thanks for your PR! |
azat
force-pushed
the
coeur/BCryptGenRandom
branch
from
c9a655c to
6fa8ccc
Compare
Coeur
force-pushed
the
coeur/BCryptGenRandom
branch
from
6fa8ccc to
97a86bf
Compare
Member
|
@Coeur IDK if/when we're going to create a
So I'm going to decline this PR as-is with it targeting What I would be OK with is cherry-picking a specific bugfix into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all, Transmission's fork of libevent needs a
post-2.2.0-transmissionbranch:https://github.com/transmission/libevent/branches/all
Once created, we can retarget this PR to the new 2.2 branch.
Then, regarding the scope of this PR, it's the same as libevent#1813 and is needed for Transmission to migrate from libevent 2.1 to libevent 2.2 (transmission/transmission#7765).