♻️ 1155 changes#89
Merged
transmissions11 merged 1 commit intotransmissions11:audit-fixesfrom Dec 28, 2021
RagePit:1155-changes
Merged
♻️ 1155 changes#89transmissions11 merged 1 commit intotransmissions11:audit-fixesfrom RagePit:1155-changes
transmissions11 merged 1 commit intotransmissions11:audit-fixesfrom
RagePit:1155-changes
Conversation
RagePit
commented
Dec 28, 2021
Comment on lines
+35
to
+38
| //if ids array has any dupes amounts will not be correct | ||
| for (uint256 j = 0; j < i; j++) { | ||
| if (ids[i] == ids[j]) return; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
These shit for fuzzing times but will fail with dupes otherwise. Could use a better test solution or just ignore the fails
Owner
|
thx! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimized the unchecked{} portions of 1155. Included test gas usage above some of the blocks.
safeTransferFrom and safeBatchTransferFrom needs to have the -= as a checked operation to prevent an attacker from underflowing their balance since we aren't verifying the balance implicitly.
https://github.com/RagePit/solmate-1155 for quick underflow demo
I'm a git and sol noob so would appreciate pointing out mistakes I made