Fix cosig timestamp endianness#153
Merged
AlCutter merged 1 commit intotransparency-dev:mainfrom Oct 3, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #153 +/- ##
==========================================
- Coverage 82.57% 77.24% -5.33%
==========================================
Files 5 6 +1
Lines 241 334 +93
==========================================
+ Hits 199 258 +59
- Misses 30 45 +15
- Partials 12 31 +19 ☔ View full report in Codecov by Sentry. |
mhutchinson
approved these changes
Oct 3, 2024
mhutchinson
added a commit
to mhutchinson/distributor
that referenced
this pull request
Oct 16, 2024
This change has two main aspects, but they are related. The first is that we now overwrite a checkpoint from a witness even if we have previously seen one of the same size. This allows infrequently updated checkpoints to have fresh witness signature timestamps. The other change is to only check the witness note signature, and not the cosignatureV1. This is a temporary change to allow signatures from the fixed implementation of this signer (transparency-dev/formats#153) to propagate into the distributor storage.
mhutchinson
added a commit
to transparency-dev/distributor
that referenced
this pull request
Oct 16, 2024
This change has two main aspects, but they are related. The first is that we now overwrite a checkpoint from a witness even if we have previously seen one of the same size. This allows infrequently updated checkpoints to have fresh witness signature timestamps. The other change is to only check the witness note signature, and not the cosignatureV1. This is a temporary change to allow signatures from the fixed implementation of this signer (transparency-dev/formats#153) to propagate into the distributor storage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR corrects the formatting of the timestamp in CoSigv1 signatures.
Previously it was encoded as LE, but should have been BE.