Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #66 +/- ##
============================================
- Coverage 100.00% 81.73% -18.27%
============================================
Files 3 5 +2
Lines 55 230 +175
============================================
+ Hits 55 188 +133
- Misses 0 30 +30
- Partials 0 12 +12 ☔ View full report in Codecov by Sentry. |
roger2hk
left a comment
There was a problem hiding this comment.
LGTM assuming this is a direct copy from transparency-dev/witness/internal/note. Found some minor difference in note/note_verifier.go and note_verifier_test.go.
I've changed the |
|
(@roger2hk sorry, will need another LTGM since I added another commit) |
This PR migrates the note signer/verifier implementations from transparency-dev/witness/internal/note with a small tweak to the API to use the embedded
algfield in the pubkey.