Tighten up POSIX file operations#481
Merged
AlCutter merged 5 commits intotransparency-dev:mainfrom Feb 11, 2025
Merged
Conversation
AlCutter
force-pushed
the
fix_posix
branch
3 times, most recently
from
88dc7fe to
4c2e2b4
Compare
AlCutter
force-pushed
the
fix_posix
branch
2 times, most recently
from
e9597f8 to
b77cf34
Compare
roger2hk
reviewed
Feb 11, 2025
storage/posix/files.go
Outdated
| if err := createExclusive(p, d); err != nil { | ||
| if errors.Is(err, os.ErrExist) { | ||
| if r, err := os.ReadFile(p); err != nil { | ||
|
|
Contributor
There was a problem hiding this comment.
Is this line intended to be empty?
Collaborator
Author
There was a problem hiding this comment.
Oops, no - removed.
roger2hk
approved these changes
Feb 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tightens the semantics of the file operations performed by the POSIX storage implementation.
It splits "writing files" across 3 narrower funcs which are then called by the storage driver depending on exactly which behaviour is intended.