Add POSIX Antispam Metrics#913
Merged
Merged
Conversation
phbnf
requested review from
AlCutter and
roger2hk
and removed request for
roger2hk
AlCutter
approved these changes
Mar 23, 2026
| gcCounter.Add(ctx, 1, attr) | ||
| gcDuration.Record(ctx, float64(time.Since(start).Microseconds())/1000.0, attr) | ||
| if err == nil { | ||
| goto again |
Collaborator
There was a problem hiding this comment.
Might be interesting to have a histogram of "how many immediately-successive GC runs before hitting no_rewrite"?
Contributor
Author
There was a problem hiding this comment.
How it counts the number of success instead of counting the number of no_rewrite :)
| } | ||
|
|
||
| followTxnEntriesCounter, err = meter.Int64Histogram( | ||
| "tessera.antispam.badger.FollowTxn.entries.count", |
Collaborator
There was a problem hiding this comment.
Maybe lowercase FollowTxn / follow_txn - all other names are lowercase.
| } | ||
|
|
||
| followTxnDuration, err = meter.Float64Histogram( | ||
| "tessera.antispam.badger.FollowTxn.duration", |
AlCutter
approved these changes
Mar 23, 2026
AlCutter
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #912.
This PR adds a few Antispam metrics for: