[PublicationAwaiter] Don't fail awaiting on a single error#925
Merged
Conversation
AlCutter
approved these changes
Apr 1, 2026
This changes the Await loop so that it no longer fails on a single transient error when fetching/parsing the checkpoint. For now this is set to fail on two consecutive errors, but perhaps this should be changed to keep trying until the context is cancelled for maximum stickiness. For now, this seems like a pragmatic compromise between these worlds. This is important because it will make the write path for logs more likely to return happy status codes if there are intermittent problems reading checkpoint storage.
Co-authored-by: Al Cutter <alcutter@google.com>
Co-authored-by: Al Cutter <alcutter@google.com>
mhutchinson
force-pushed
the
awaiterTweaks
branch
from
8077d65 to
35bc922
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the Await loop so that it no longer fails on a single transient error when fetching/parsing the checkpoint. For now this is set to fail on two consecutive errors, but perhaps this should be changed to keep trying until the context is cancelled for maximum stickiness. For now, this seems like a pragmatic compromise between these worlds.
This is important because it will make the write path for logs more likely to return happy status codes if there are intermittent problems reading checkpoint storage.