[POSIX] Fixed symlinking partial tiles#972
Merged
Merged
Conversation
The POSIX storage driver in `writeTile` cleanup failed to clean up old partial tiles due to two path-resolution bugs: 1. it ran `filepath.Glob` using relative tile paths, causing searches to resolve relative to the process's current working directory (CWD) instead of the log storage root 2. it created symlinks pointing to `tPath` (e.g., `tile/0/000`), which became broken once renamed into the `.p/` subdirectory (resolving as `tile/0/000.p/tile/0/000`). Fixed these bugs by prepending the storage root to all glob and temp paths to ensure CWD independence, calculating the correct relative target pointing from the symlink directory to the full tile using `filepath.Rel`.
AlCutter
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The POSIX storage driver in
writeTilecleanup failed to clean up old partial tiles due to two path-resolution bugs:filepath.Globusing relative tile paths, causing searches to resolve relative to the process's current working directory (CWD) instead of the log storage roottPath(e.g.,tile/0/000), which became broken once renamed into the.p/subdirectory (resolving astile/0/000.p/tile/0/000).Fixed these bugs by prepending the storage root to all glob and temp paths to ensure CWD independence, calculating the correct relative target pointing from the symlink directory to the full tile using
filepath.Rel.