-
Notifications
You must be signed in to change notification settings - Fork 13
Add fsck TUI #562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fsck TUI #562
Conversation
|
Very quick comment on the UI before I dive into the code and following up on our conversation this morning: does "unchecked" mean "unfetched", or does it mean more than that? I'd say that "checking" a leaf is very overloaded, and will be even more overloaded for CT when/if we add checks to make sure that leaves are formatted properly, SCTs are valid. |
It means "a resource whose existence is implied by the size of the checkpoint, but which we have not interacted with". There is no "Checked" state distinct from the "OK" state, so I don't think we need to worry too much about that at the mo'? |
|
Agreed that we don't need to worry too much about this. Putting aside additional checks that might or might not happen for CT at some point, I think I'd rather use "TODO" than "Unchecked": I can't tell whether unchecked refers to "checking the data in" i.e downloading it, or "running a check on the data" i.e rehashing everything, or both. But also, I'm not a native english speaker. This is not blocking this PR anyways since this is defined in the Tessera repo and can be changed later. |
Yeah, I suggested
From fsck's PoV Tricksy! |
|
Drive by comment - this UI looks awesome! I was running fsck over the weekend and wanting exactly this to know that it was running. |
Bumps Tessera and updates the local

fscktool to support a TUI.