Skip to content

Conversation

@AlCutter
Copy link
Collaborator

@AlCutter AlCutter commented Sep 16, 2025

Bumps Tessera and updates the local fsck tool to support a TUI.
progress

@AlCutter AlCutter marked this pull request as ready for review September 17, 2025 13:44
@AlCutter AlCutter requested a review from a team as a code owner September 17, 2025 13:44
@AlCutter AlCutter requested review from a team, phbnf and roger2hk and removed request for a team September 17, 2025 13:44
@phbnf
Copy link
Collaborator

phbnf commented Sep 17, 2025

Very quick comment on the UI before I dive into the code and following up on our conversation this morning: does "unchecked" mean "unfetched", or does it mean more than that?

I'd say that "checking" a leaf is very overloaded, and will be even more overloaded for CT when/if we add checks to make sure that leaves are formatted properly, SCTs are valid.

@AlCutter
Copy link
Collaborator Author

AlCutter commented Sep 17, 2025

Very quick comment on the UI before I dive into the code and following up on our conversation this morning: does "unchecked" mean "unfetched", or does it mean more than that?

I'd say that "checking" a leaf is very overloaded, and will be even more overloaded for CT when/if we add checks to make sure that leaves are formatted properly, SCTs are valid.

It means "a resource whose existence is implied by the size of the checkpoint, but which we have not interacted with".

There is no "Checked" state distinct from the "OK" state, so I don't think we need to worry too much about that at the mo'?

@phbnf
Copy link
Collaborator

phbnf commented Sep 17, 2025

Agreed that we don't need to worry too much about this.

Putting aside additional checks that might or might not happen for CT at some point, I think I'd rather use "TODO" than "Unchecked": I can't tell whether unchecked refers to "checking the data in" i.e downloading it, or "running a check on the data" i.e rehashing everything, or both. But also, I'm not a native english speaker. This is not blocking this PR anyways since this is defined in the Tessera repo and can be changed later.

@AlCutter
Copy link
Collaborator Author

AlCutter commented Sep 17, 2025

Agreed that we don't need to worry too much about this.

Putting aside additional checks that might or might not happen for CT at some point, I think I'd rather use "TODO" than "Unchecked": I can't tell whether unchecked refers to "checking the data in" i.e downloading it, or "running a check on the data" i.e rehashing everything, or both. But also, I'm not a native english speaker. This is not blocking this PR anyways since this is defined in the Tessera repo and can be changed later.

Yeah, I suggested TODO originally as a possibility but then cooled off on it because:

  • it kinda looks weird in the UI - e.g. prompting "Is that bit of the UI unimplemented currently?", or "Is there a missing validation step of some kind which has a placeholder in the UI but is not implemented yet?"
  • it's not clear what it means as a State of a resource - "is that resource not yet created?"

From fsck's PoV Unknown is really what the State is (until it, er, knows), which left me looking for something meaning "I've not yet looked at this" so I went with Unchecked.

Tricksy!

@AlCutter AlCutter merged commit 9068d37 into transparency-dev:main Sep 17, 2025
9 checks passed
@AlCutter AlCutter deleted the fsck_ui branch September 17, 2025 14:36
@haydentherapper
Copy link

Drive by comment - this UI looks awesome! I was running fsck over the weekend and wanting exactly this to know that it was running.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants