Skip to content

Add RFC3339 format validation to date-related input variables#818

Merged
roger2hk merged 4 commits intotransparency-dev:mainfrom
roger2hk:tf-validate-date-variables
Mar 31, 2026
Merged

Add RFC3339 format validation to date-related input variables#818
roger2hk merged 4 commits intotransparency-dev:mainfrom
roger2hk:tf-validate-date-variables

Conversation

@roger2hk
Copy link
Copy Markdown
Contributor

@roger2hk roger2hk commented Mar 30, 2026 •
edited
Loading 

➜  tesseract git:(tf-validate-date-variables) tofu -chdir=deployment/modules/gcp/gce/tesseract test
tests/variables_validation.tftest.hcl... pass
  run "valid_dates"... pass
  run "invalid_dates_not_after_start_format"... pass
  run "invalid_dates_not_after_limit_format"... pass
  run "invalid_dates_start_after_limit"... pass
  run "invalid_dates_equal"... pass
  run "valid_dates_start_empty"... pass
  run "valid_dates_limit_empty"... pass
  run "valid_dates_both_empty"... pass
  run "valid_dates_fractional_seconds"... pass
  run "valid_dates_offsets"... pass
  run "invalid_dates_not_after_start_lowercase"... pass
  run "invalid_dates_not_after_limit_lowercase"... pass

Success! 12 passed, 0 failed.

@roger2hk roger2hk requested a review from phbnf March 30, 2026 17:33
@roger2hk roger2hk requested a review from a team as a code owner March 30, 2026 17:33
@phbnf
Copy link
Copy Markdown
Collaborator

phbnf commented Mar 31, 2026

Neat - that would definitely have saved me time as I got this wrong already!

@roger2hk
Copy link
Copy Markdown
Contributor Author

roger2hk commented Mar 31, 2026

Added the test command and its result to the pull request description.

phbnf
phbnf reviewed Mar 31, 2026
View reviewed changes
@roger2hk roger2hk requested a review from phbnf March 31, 2026 15:33
phbnf
phbnf approved these changes Mar 31, 2026
View reviewed changes
@roger2hk roger2hk merged commit a84dba1 into transparency-dev:main Mar 31, 2026
10 checks passed
@roger2hk roger2hk deleted the tf-validate-date-variables branch March 31, 2026 16:38
@roger2hk roger2hk mentioned this pull request Mar 31, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phbnf phbnf phbnf approved these changes

Assignees

@phbnf phbnf

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@roger2hk @phbnf