Skip to content

Conversation

Copy link

Copilot AI commented Aug 24, 2025

This PR updates the span-stacktrace module to align with the project's style guide requirements with minimal changes:

Changes Made

1. Added final keyword to public classes

  • Made StackTraceSpanProcessor and StackTraceAutoConfig final per the style guide requirement that "Public non-internal classes should be declared final where possible"

2. Added static imports for logging levels

  • Added static imports for Level.FINE and Level.SEVERE in StackTraceAutoConfig
  • Updated usage from Level.FINE to FINE and Level.SEVERE to SEVERE following the style guide recommendation for commonly used constants

3. Made test class package-protected

  • Removed public modifier from StackTraceAutoConfigTest to follow the guideline that "Test classes and test methods should generally be package-protected (no explicit visibility modifier) rather than public"

All changes maintain backward compatibility and the module continues to build successfully with all tests passing.

Fixes #284.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • scans-in.gradle.com
    • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED -XX:MaxMetaspaceSize=512m -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant -cp /home/REDACTED/.gradle/wrapper/dists/gradle-9.0.0-bin/d6wjpkvcgsg3oed0qlfss3wgl/gradle-9.0.0/lib/gradle-daemon-main-9.0.0.jar -javaagent:/home/REDACTED/.gradle/wrapper/dists/gradle-9.0.0-bin/d6wjpkvcgsg3oed0qlfss3wgl/gradle-9.0.0/lib/agents/gradle-instrumentation-agent-9.0.0.jar org.gradle.launcher.daemon.bootstrap.GradleDaemon 9.0.0 (dns block)

If you need me to access, download, or install something from one of these locations, you can either:


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: trask <218610+trask@users.noreply.github.com>
Copilot AI changed the title [WIP] Update span-stacktrace module to follow style guide Update span-stacktrace module to follow style guide Aug 24, 2025
Copilot AI requested a review from trask August 24, 2025 20:38
Copilot finished work on behalf of trask August 24, 2025 20:38
@trask trask closed this Aug 24, 2025
@trask trask deleted the copilot/fix-284 branch October 20, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update span-stacktrace module to follow style guide

2 participants